Discussion:
[edk2] [PATCH] MdePkg: Refine INF file for SmmMemLib.
Qiu Shumin
2015-07-08 07:53:51 UTC
Permalink
Add [Depex] section and update protocol usage.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu Shumin <***@intel.com>
CC: Liming Gao <***@intel.com>
CC: "Yao, Jiewen" <***@intel.com>
---
MdePkg/Library/SmmMemLib/SmmMemLib.inf | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/MdePkg/Library/SmmMemLib/SmmMemLib.inf b/MdePkg/Library/SmmMemLib/SmmMemLib.inf
index 5531423..a9d47cc 100644
--- a/MdePkg/Library/SmmMemLib/SmmMemLib.inf
+++ b/MdePkg/Library/SmmMemLib/SmmMemLib.inf
@@ -49,4 +49,7 @@
MemoryAllocationLib

[Protocols]
- gEfiSmmAccess2ProtocolGuid ## SOMETIMES_CONSUMES
+ gEfiSmmAccess2ProtocolGuid ## CONSUMES
+
+[Depex]
+ gEfiSmmAccess2ProtocolGuid
--
1.9.5.msysgit.1
Yao, Jiewen
2015-07-08 07:54:50 UTC
Permalink
Looks good.

-----Original Message-----
From: Qiu, Shumin
Sent: Wednesday, July 08, 2015 3:54 PM
To: edk2-***@lists.sourceforge.net
Cc: Qiu, Shumin; Gao, Liming; Yao, Jiewen
Subject: [edk2][PATCH] MdePkg: Refine INF file for SmmMemLib.

Add [Depex] section and update protocol usage.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu Shumin <***@intel.com>
CC: Liming Gao <***@intel.com>
CC: "Yao, Jiewen" <***@intel.com>
---
MdePkg/Library/SmmMemLib/SmmMemLib.inf | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/MdePkg/Library/SmmMemLib/SmmMemLib.inf b/MdePkg/Library/SmmMemLib/SmmMemLib.inf
index 5531423..a9d47cc 100644
--- a/MdePkg/Library/SmmMemLib/SmmMemLib.inf
+++ b/MdePkg/Library/SmmMemLib/SmmMemLib.inf
@@ -49,4 +49,7 @@
MemoryAllocationLib

[Protocols]
- gEfiSmmAccess2ProtocolGuid ## SOMETIMES_CONSUMES
+ gEfiSmmAccess2ProtocolGuid ## CONSUMES
+
+[Depex]
+ gEfiSmmAccess2ProtocolGuid
--
1.9.5.msysgit.1
Laszlo Ersek
2015-07-08 12:16:54 UTC
Permalink
Post by Qiu Shumin
Add [Depex] section and update protocol usage.
Contributed-under: TianoCore Contribution Agreement 1.0
---
MdePkg/Library/SmmMemLib/SmmMemLib.inf | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/MdePkg/Library/SmmMemLib/SmmMemLib.inf b/MdePkg/Library/SmmMemLib/SmmMemLib.inf
index 5531423..a9d47cc 100644
--- a/MdePkg/Library/SmmMemLib/SmmMemLib.inf
+++ b/MdePkg/Library/SmmMemLib/SmmMemLib.inf
@@ -49,4 +49,7 @@
MemoryAllocationLib
[Protocols]
- gEfiSmmAccess2ProtocolGuid ## SOMETIMES_CONSUMES
+ gEfiSmmAccess2ProtocolGuid ## CONSUMES
+
+[Depex]
+ gEfiSmmAccess2ProtocolGuid
The subject line is useless. If someone runs

git log --oneline

which prints only the commit hashes and the subject lines, he will see

MdePkg: Refine INF file for SmmMemLib.

which carries zero meaning. The subject line should be:

MdePkg: SmmMemLib.inf: add Depex section and update protocol usage

Thanks
Laszlo

Loading...