Discussion:
[edk2] GetTime - TimeZone
Sivasakthivel Nainar
2015-09-03 19:52:38 UTC
Permalink
Below both are different Real Time clock implementations in EDK II source.

ArmPlatformPkg/Library/PL031RealTimeClockLib/PL031RealTimeClockLib.c

PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcRtc.c

One is adjusting the Time with Timezone value programmed and other one ( PC code ) is not adjusting. I think UEFI spec does not ask to adjust the time to timezone.

ArmPlatformPkg/Library/PL031RealTimeClockLib/PL031RealTimeClockLib.c implementation may need to be reviewed.

The information contained in this message may be confidential and proprietary to American Megatrends, Inc. This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.
Andrew Fish
2015-09-03 20:21:40 UTC
Permalink
Post by Sivasakthivel Nainar
Below both are different Real Time clock implementations in EDK II source.
ArmPlatformPkg/Library/PL031RealTimeClockLib/PL031RealTimeClockLib.c
PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcRtc.c
One is adjusting the Time with Timezone value programmed and other one ( PC code ) is not adjusting. I think UEFI spec does not ask to adjust the time to timezone.
The Spec, which probably is a little too PC centric, states that TimeZone, and Daylight come from values set via SetTime(). I would posit if the RTC stores the TimeZone and Daylight information, then it makes sense to return that info.

Thanks,

Andrew Fish
Post by Sivasakthivel Nainar
ArmPlatformPkg/Library/PL031RealTimeClockLib/PL031RealTimeClockLib.c implementation may need to be reviewed.
The information contained in this message may be confidential and proprietary to American Megatrends, Inc. This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.
------------------------------------------------------------------------------
Monitor Your Dynamic Infrastructure at Any Scale With Datadog!
Get real-time metrics from all of your servers, apps and tools
in one place.
SourceForge users - Click here to start your Free Trial of Datadog now!
https://urldefense.proofpoint.com/v2/url?u=http-3A__pubads.g.doubleclick.net_gampad_clk-3Fid-3D241902991-26iu-3D_4140&d=BQICAg&c=eEvniauFctOgLOKGJOplqw&r=1HnUuXD1wDvw67rut5_idw&m=Hism9nC6KlTfuPZYQLFLdUNQe5rjowHx5EmCA4_Wa_E&s=d7TY3q2cp-QF5SkUPEH_TjQt7IVQg2lp3gFMqFTJftw&e=
_______________________________________________
edk2-devel mailing list
https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.sourceforge.net_lists_listinfo_edk2-2Ddevel&d=BQICAg&c=eEvniauFctOgLOKGJOplqw&r=1HnUuXD1wDvw67rut5_idw&m=Hism9nC6KlTfuPZYQLFLdUNQe5rjowHx5EmCA4_Wa_E&s=ECollaIBK78uEC6-NsVpsafMVhNvvO5fkFpeFWM7MJg&e=
Continue reading on narkive:
Loading...