[edk2] [PATCH] Bump default driver supported efi version to 2.5

Discussion:

Bruce Cran

2015-05-29 01:17:48 UTC

I noticed that the default value used for the driver supported efi
version protocol was 0x2000a - UEFI 2.1. The attached patch bumps it to
2.5 and updates the NvmExpress driver to use the Pcd from OptionRomPkg.

--
Bruce

Tian, Feng

2015-05-29 08:41:20 UTC

Permalink

Hi, Bruce

The modules in MdeModulePkg couldn't depend on OptionRomPkg. So your change is not ok for me.

I would prefer to directly assign 0x00020032 to gNvmExpressDriverSupportedEfiVersion.FirmwareVersion.

Thanks
Feng

-----Original Message-----
From: Bruce Cran [mailto:***@cran.org.uk]
Sent: Friday, May 29, 2015 09:18
To: edk2-***@lists.sourceforge.net
Subject: [edk2] [PATCH] Bump default driver supported efi version to 2.5

I noticed that the default value used for the driver supported efi version protocol was 0x2000a - UEFI 2.1. The attached patch bumps it to
2.5 and updates the NvmExpress driver to use the Pcd from OptionRomPkg.

--
Bruce
------------------------------------------------------------------------------

Bruce Cran

2015-05-29 15:25:30 UTC

Permalink

Thanks. I've attached a new version of the patch.
--
Bruce

Post by Tian, Feng
Hi, Bruce
The modules in MdeModulePkg couldn't depend on OptionRomPkg. So your change is not ok for me.
I would prefer to directly assign 0x00020032 to gNvmExpressDriverSupportedEfiVersion.FirmwareVersion.
Thanks
Feng
-----Original Message-----
Sent: Friday, May 29, 2015 09:18
Subject: [edk2] [PATCH] Bump default driver supported efi version to 2.5
I noticed that the default value used for the driver supported efi version protocol was 0x2000a - UEFI 2.1. The attached patch bumps it to
2.5 and updates the NvmExpress driver to use the Pcd from OptionRomPkg.
--
Bruce

Tian, Feng

2015-06-01 02:58:19 UTC

Permalink

Could you split it to 2 patches? One is specific for MdeModulePkg and another is for OpromPkg. Then different package owners could review your changes individually.

MdeModulePkg change is good: Reviewed-by: Feng Tian <***@intel.com>

I will help check in the MdeModulePkg part.

Thanks
Feng

-----Original Message-----
From: Bruce Cran [mailto:***@cran.org.uk]
Sent: Friday, May 29, 2015 23:26
To: Tian, Feng; edk2-***@lists.sourceforge.net
Subject: Re: [edk2] [PATCH] Bump default driver supported efi version to 2.5

Thanks. I've attached a new version of the patch.
--
Bruce

------------------------------------------------------------------------------

Tian, Feng

2015-06-23 01:02:08 UTC

Permalink

Hi, Bruce

I found we should use EFI_SPECIFICATION_VERSION macro here rather than hardcode it to a 0x000200xx value. Do you agree?

Thanks
Feng

-----Original Message-----
From: Tian, Feng
Sent: Monday, June 01, 2015 10:58
To: Bruce Cran; edk2-***@lists.sourceforge.net
Cc: Tian, Feng
Subject: RE: [edk2] [PATCH] Bump default driver supported efi version to 2.5

Could you split it to 2 patches? One is specific for MdeModulePkg and another is for OpromPkg. Then different package owners could review your changes individually.

MdeModulePkg change is good: Reviewed-by: Feng Tian <***@intel.com>

I will help check in the MdeModulePkg part.

Thanks
Feng

-----Original Message-----
From: Bruce Cran [mailto:***@cran.org.uk]
Sent: Friday, May 29, 2015 23:26
To: Tian, Feng; edk2-***@lists.sourceforge.net
Subject: Re: [edk2] [PATCH] Bump default driver supported efi version to 2.5

Thanks. I've attached a new version of the patch.
--
Bruce