Discussion:
[edk2] [PATCH] SecurityPkg: Add MD5 support to Hash2DxeCrypto
Jonathan Doman
2015-06-05 16:07:01 UTC
Permalink
MD5 is part of the HASH2 protocol and it's trivial to support.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jonathan Doman <***@hp.com>
---
SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.c | 2 ++
SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.inf | 4 +++-
2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.c b/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.c
index 92cda36..114ba5e 100644
--- a/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.c
+++ b/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.c
@@ -1,6 +1,7 @@
/** @file
This module implements Hash2 Protocol.

+ (C) Copyright 2015 Hewlett-Packard Development Company, L.P.<BR>
Copyright (c) 2015, Intel Corporation. All rights reserved.<BR>
This program and the accompanying materials are licensed and made available under
the terms and conditions of the BSD License that accompanies this distribution.
@@ -125,6 +126,7 @@ typedef struct {
} EFI_HASH_INFO;

EFI_HASH_INFO mHashInfo[] = {
+ {&gEfiHashAlgorithmMD5Guid, sizeof(EFI_MD5_HASH2), Md5GetContextSize, Md5Init, Md5Update, Md5Final },
{&gEfiHashAlgorithmSha1Guid, sizeof(EFI_SHA1_HASH2), Sha1GetContextSize, Sha1Init, Sha1Update, Sha1Final },
{&gEfiHashAlgorithmSha256Guid, sizeof(EFI_SHA256_HASH2), Sha256GetContextSize, Sha256Init, Sha256Update, Sha256Final },
{&gEfiHashAlgorithmSha384Guid, sizeof(EFI_SHA384_HASH2), Sha384GetContextSize, Sha384Init, Sha384Update, Sha384Final },
diff --git a/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.inf b/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.inf
index 1dce002..a631cfb 100644
--- a/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.inf
+++ b/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.inf
@@ -3,6 +3,7 @@
#
# This module will use EDKII crypto libary to HASH2 protocol.
#
+# (C) Copyright 2015 Hewlett-Packard Development Company, L.P.<BR>
# Copyright (c) 2015, Intel Corporation. All rights reserved.<BR>
# This program and the accompanying materials
# are licensed and made available under the terms and conditions of the BSD License
@@ -49,6 +50,7 @@
UefiLib

[Guids]
+ gEfiHashAlgorithmMD5Guid ## CONSUMES ## GUID
gEfiHashAlgorithmSha1Guid ## CONSUMES ## GUID
gEfiHashAlgorithmSha256Guid ## CONSUMES ## GUID
gEfiHashAlgorithmSha384Guid ## CONSUMES ## GUID
@@ -59,4 +61,4 @@
gEfiHash2ServiceBindingProtocolGuid ## PRODUCES

[UserExtensions.TianoCore."ExtraFiles"]
- Hash2DxeCryptoExtra.uni
\ No newline at end of file
+ Hash2DxeCryptoExtra.uni
--
2.4.2


------------------------------------------------------------------------------
El-Haj-Mahmoud, Samer
2015-06-18 17:27:27 UTC
Permalink
Reviewed-by: Samer El-Haj-Mahmoud <samer.el-haj-***@hp.com>



-----Original Message-----
From: Doman, Jonathan
Sent: Friday, June 05, 2015 12:07 PM
To: edk2-***@lists.sourceforge.net
Subject: [edk2] [PATCH] SecurityPkg: Add MD5 support to Hash2DxeCrypto

MD5 is part of the HASH2 protocol and it's trivial to support.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jonathan Doman <***@hp.com>
---
SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.c | 2 ++
SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.inf | 4 +++-
2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.c b/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.c
index 92cda36..114ba5e 100644
--- a/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.c
+++ b/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.c
@@ -1,6 +1,7 @@
/** @file
This module implements Hash2 Protocol.

+ (C) Copyright 2015 Hewlett-Packard Development Company, L.P.<BR>
Copyright (c) 2015, Intel Corporation. All rights reserved.<BR> This program and the accompanying materials are licensed and made available under the terms and conditions of the BSD License that accompanies this distribution.
@@ -125,6 +126,7 @@ typedef struct {
} EFI_HASH_INFO;

EFI_HASH_INFO mHashInfo[] = {
+ {&gEfiHashAlgorithmMD5Guid, sizeof(EFI_MD5_HASH2), Md5GetContextSize, Md5Init, Md5Update, Md5Final },
{&gEfiHashAlgorithmSha1Guid, sizeof(EFI_SHA1_HASH2), Sha1GetContextSize, Sha1Init, Sha1Update, Sha1Final },
{&gEfiHashAlgorithmSha256Guid, sizeof(EFI_SHA256_HASH2), Sha256GetContextSize, Sha256Init, Sha256Update, Sha256Final },
{&gEfiHashAlgorithmSha384Guid, sizeof(EFI_SHA384_HASH2), Sha384GetContextSize, Sha384Init, Sha384Update, Sha384Final }, diff --git a/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.inf b/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.inf
index 1dce002..a631cfb 100644
--- a/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.inf
+++ b/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.inf
@@ -3,6 +3,7 @@
#
# This module will use EDKII crypto libary to HASH2 protocol.
#
+# (C) Copyright 2015 Hewlett-Packard Development Company, L.P.<BR>
# Copyright (c) 2015, Intel Corporation. All rights reserved.<BR> # This program and the accompanying materials # are licensed and made available under the terms and conditions of the BSD License @@ -49,6 +50,7 @@
UefiLib

[Guids]
+ gEfiHashAlgorithmMD5Guid ## CONSUMES ## GUID
gEfiHashAlgorithmSha1Guid ## CONSUMES ## GUID
gEfiHashAlgorithmSha256Guid ## CONSUMES ## GUID
gEfiHashAlgorithmSha384Guid ## CONSUMES ## GUID
@@ -59,4 +61,4 @@
gEfiHash2ServiceBindingProtocolGuid ## PRODUCES

[UserExtensions.TianoCore."ExtraFiles"]
- Hash2DxeCryptoExtra.uni
\ No newline at end of file
+ Hash2DxeCryptoExtra.uni
--
2.4.2
El-Haj-Mahmoud, Samer
2015-06-27 21:28:29 UTC
Permalink
If there is no additional feedback on this, can someone please check it in?



-----Original Message-----
From: El-Haj-Mahmoud, Samer
Sent: Thursday, June 18, 2015 12:27 PM
To: edk2-***@lists.sourceforge.net
Subject: Re: [edk2] [PATCH] SecurityPkg: Add MD5 support to Hash2DxeCrypto

Reviewed-by: Samer El-Haj-Mahmoud <samer.el-haj-***@hp.com>



-----Original Message-----
From: Doman, Jonathan
Sent: Friday, June 05, 2015 12:07 PM
To: edk2-***@lists.sourceforge.net
Subject: [edk2] [PATCH] SecurityPkg: Add MD5 support to Hash2DxeCrypto

MD5 is part of the HASH2 protocol and it's trivial to support.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jonathan Doman <***@hp.com>
---
SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.c | 2 ++
SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.inf | 4 +++-
2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.c b/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.c
index 92cda36..114ba5e 100644
--- a/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.c
+++ b/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.c
@@ -1,6 +1,7 @@
/** @file
This module implements Hash2 Protocol.

+ (C) Copyright 2015 Hewlett-Packard Development Company, L.P.<BR>
Copyright (c) 2015, Intel Corporation. All rights reserved.<BR> This program and the accompanying materials are licensed and made available under the terms and conditions of the BSD License that accompanies this distribution.
@@ -125,6 +126,7 @@ typedef struct {
} EFI_HASH_INFO;

EFI_HASH_INFO mHashInfo[] = {
+ {&gEfiHashAlgorithmMD5Guid, sizeof(EFI_MD5_HASH2), Md5GetContextSize, Md5Init, Md5Update, Md5Final },
{&gEfiHashAlgorithmSha1Guid, sizeof(EFI_SHA1_HASH2), Sha1GetContextSize, Sha1Init, Sha1Update, Sha1Final },
{&gEfiHashAlgorithmSha256Guid, sizeof(EFI_SHA256_HASH2), Sha256GetContextSize, Sha256Init, Sha256Update, Sha256Final },
{&gEfiHashAlgorithmSha384Guid, sizeof(EFI_SHA384_HASH2), Sha384GetContextSize, Sha384Init, Sha384Update, Sha384Final }, diff --git a/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.inf b/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.inf
index 1dce002..a631cfb 100644
--- a/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.inf
+++ b/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.inf
@@ -3,6 +3,7 @@
#
# This module will use EDKII crypto libary to HASH2 protocol.
#
+# (C) Copyright 2015 Hewlett-Packard Development Company, L.P.<BR>
# Copyright (c) 2015, Intel Corporation. All rights reserved.<BR> # This program and the accompanying materials # are licensed and made available under the terms and conditions of the BSD License @@ -49,6 +50,7 @@
UefiLib

[Guids]
+ gEfiHashAlgorithmMD5Guid ## CONSUMES ## GUID
gEfiHashAlgorithmSha1Guid ## CONSUMES ## GUID
gEfiHashAlgorithmSha256Guid ## CONSUMES ## GUID
gEfiHashAlgorithmSha384Guid ## CONSUMES ## GUID
@@ -59,4 +61,4 @@
gEfiHash2ServiceBindingProtocolGuid ## PRODUCES

[UserExtensions.TianoCore."ExtraFiles"]
- Hash2DxeCryptoExtra.uni
\ No newline at end of file
+ Hash2DxeCryptoExtra.uni
--
2.4.2


------------------------------------------------------------------------------
_______________________________________________
edk2-devel mailing list
edk2-***@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

------------------------------------------------------------------------------
_______________________________________________
edk2-devel mailing list
edk2-***@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel
Laszlo Ersek
2015-06-28 11:56:55 UTC
Permalink
Post by El-Haj-Mahmoud, Samer
If there is no additional feedback on this, can someone please check it in?
I could commit it for you guys, but the Signed-off-by of SecurityPkg's
maintainer (Cc'd) is missing.

Is the problem perhaps that he may not have been Cc'd on the initial
submission? It's best to consult the Maintainers.txt file, and Cc the
package maintainer directly (with Cc: tags in the commit message, to be
handled by git-send-email).

Thanks
Laszlo
Post by El-Haj-Mahmoud, Samer
-----Original Message-----
From: El-Haj-Mahmoud, Samer
Sent: Thursday, June 18, 2015 12:27 PM
Subject: Re: [edk2] [PATCH] SecurityPkg: Add MD5 support to Hash2DxeCrypto
-----Original Message-----
From: Doman, Jonathan
Sent: Friday, June 05, 2015 12:07 PM
Subject: [edk2] [PATCH] SecurityPkg: Add MD5 support to Hash2DxeCrypto
MD5 is part of the HASH2 protocol and it's trivial to support.
Contributed-under: TianoCore Contribution Agreement 1.0
---
SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.c | 2 ++
SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.inf | 4 +++-
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.c b/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.c
index 92cda36..114ba5e 100644
--- a/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.c
+++ b/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.c
@@ -1,6 +1,7 @@
This module implements Hash2 Protocol.
+ (C) Copyright 2015 Hewlett-Packard Development Company, L.P.<BR>
Copyright (c) 2015, Intel Corporation. All rights reserved.<BR> This program and the accompanying materials are licensed and made available under the terms and conditions of the BSD License that accompanies this distribution.
@@ -125,6 +126,7 @@ typedef struct {
} EFI_HASH_INFO;
EFI_HASH_INFO mHashInfo[] = {
+ {&gEfiHashAlgorithmMD5Guid, sizeof(EFI_MD5_HASH2), Md5GetContextSize, Md5Init, Md5Update, Md5Final },
{&gEfiHashAlgorithmSha1Guid, sizeof(EFI_SHA1_HASH2), Sha1GetContextSize, Sha1Init, Sha1Update, Sha1Final },
{&gEfiHashAlgorithmSha256Guid, sizeof(EFI_SHA256_HASH2), Sha256GetContextSize, Sha256Init, Sha256Update, Sha256Final },
{&gEfiHashAlgorithmSha384Guid, sizeof(EFI_SHA384_HASH2), Sha384GetContextSize, Sha384Init, Sha384Update, Sha384Final }, diff --git a/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.inf b/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.inf
index 1dce002..a631cfb 100644
--- a/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.inf
+++ b/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.inf
@@ -3,6 +3,7 @@
#
# This module will use EDKII crypto libary to HASH2 protocol.
#
+# (C) Copyright 2015 Hewlett-Packard Development Company, L.P.<BR>
UefiLib
[Guids]
+ gEfiHashAlgorithmMD5Guid ## CONSUMES ## GUID
gEfiHashAlgorithmSha1Guid ## CONSUMES ## GUID
gEfiHashAlgorithmSha256Guid ## CONSUMES ## GUID
gEfiHashAlgorithmSha384Guid ## CONSUMES ## GUID
@@ -59,4 +61,4 @@
gEfiHash2ServiceBindingProtocolGuid ## PRODUCES
[UserExtensions.TianoCore."ExtraFiles"]
- Hash2DxeCryptoExtra.uni
\ No newline at end of file
+ Hash2DxeCryptoExtra.uni
--
2.4.2
------------------------------------------------------------------------------
_______________________________________________
edk2-devel mailing list
https://lists.sourceforge.net/lists/listinfo/edk2-devel
------------------------------------------------------------------------------
_______________________________________________
edk2-devel mailing list
https://lists.sourceforge.net/lists/listinfo/edk2-devel
------------------------------------------------------------------------------
Monitor 25 network devices or servers for free with OpManager!
OpManager is web-based network management software that monitors
network devices and physical & virtual servers, alerts via email & sms
for fault. Monitor 25 devices for free with no restriction. Download now
http://ad.doubleclick.net/ddm/clk/292181274;119417398;o
_______________________________________________
edk2-devel mailing list
https://lists.sourceforge.net/lists/listinfo/edk2-devel
El-Haj-Mahmoud, Samer
2015-06-28 16:34:22 UTC
Permalink
Thanks Laszlo. I didn't know the maintainer needs to be CC'd on the patch submission. I will do that on future submissions.

Chao,

Can you review please?

Thanks,


-----Original Message-----
From: Laszlo Ersek [mailto:***@redhat.com]
Sent: Sunday, June 28, 2015 6:57 AM
To: El-Haj-Mahmoud, Samer; Doman, Jonathan
Cc: edk2-***@lists.sourceforge.net; Chao Zhang
Subject: Re: [edk2] [PATCH] SecurityPkg: Add MD5 support to Hash2DxeCrypto
Post by El-Haj-Mahmoud, Samer
If there is no additional feedback on this, can someone please check it in?
I could commit it for you guys, but the Signed-off-by of SecurityPkg's maintainer (Cc'd) is missing.

Is the problem perhaps that he may not have been Cc'd on the initial submission? It's best to consult the Maintainers.txt file, and Cc the package maintainer directly (with Cc: tags in the commit message, to be handled by git-send-email).

Thanks
Laszlo
Post by El-Haj-Mahmoud, Samer
-----Original Message-----
From: El-Haj-Mahmoud, Samer
Sent: Thursday, June 18, 2015 12:27 PM
Subject: Re: [edk2] [PATCH] SecurityPkg: Add MD5 support to
Hash2DxeCrypto
-----Original Message-----
From: Doman, Jonathan
Sent: Friday, June 05, 2015 12:07 PM
Subject: [edk2] [PATCH] SecurityPkg: Add MD5 support to Hash2DxeCrypto
MD5 is part of the HASH2 protocol and it's trivial to support.
Contributed-under: TianoCore Contribution Agreement 1.0
---
SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.c | 2 ++
SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.inf | 4 +++-
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.c
b/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.c
index 92cda36..114ba5e 100644
--- a/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.c
+++ b/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.c
@@ -1,6 +1,7 @@
This module implements Hash2 Protocol.
+ (C) Copyright 2015 Hewlett-Packard Development Company, L.P.<BR>
Copyright (c) 2015, Intel Corporation. All rights reserved.<BR> This program and the accompanying materials are licensed and made available under the terms and conditions of the BSD License that accompanies this distribution.
@@ -125,6 +126,7 @@ typedef struct {
} EFI_HASH_INFO;
EFI_HASH_INFO mHashInfo[] = {
+ {&gEfiHashAlgorithmMD5Guid, sizeof(EFI_MD5_HASH2), Md5GetContextSize, Md5Init, Md5Update, Md5Final },
{&gEfiHashAlgorithmSha1Guid, sizeof(EFI_SHA1_HASH2), Sha1GetContextSize, Sha1Init, Sha1Update, Sha1Final },
{&gEfiHashAlgorithmSha256Guid, sizeof(EFI_SHA256_HASH2), Sha256GetContextSize, Sha256Init, Sha256Update, Sha256Final },
{&gEfiHashAlgorithmSha384Guid, sizeof(EFI_SHA384_HASH2),
Sha384GetContextSize, Sha384Init, Sha384Update, Sha384Final }, diff
--git a/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.inf
b/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.inf
index 1dce002..a631cfb 100644
--- a/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.inf
+++ b/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.inf
@@ -3,6 +3,7 @@
#
# This module will use EDKII crypto libary to HASH2 protocol.
#
+# (C) Copyright 2015 Hewlett-Packard Development Company, L.P.<BR>
UefiLib
[Guids]
+ gEfiHashAlgorithmMD5Guid ## CONSUMES ## GUID
gEfiHashAlgorithmSha1Guid ## CONSUMES ## GUID
gEfiHashAlgorithmSha256Guid ## CONSUMES ## GUID
gEfiHashAlgorithmSha384Guid ## CONSUMES ## GUID
@@ -59,4 +61,4 @@
gEfiHash2ServiceBindingProtocolGuid ## PRODUCES
[UserExtensions.TianoCore."ExtraFiles"]
- Hash2DxeCryptoExtra.uni
\ No newline at end of file
+ Hash2DxeCryptoExtra.uni
--
2.4.2
----------------------------------------------------------------------
-------- _______________________________________________
edk2-devel mailing list
https://lists.sourceforge.net/lists/listinfo/edk2-devel
----------------------------------------------------------------------
-------- _______________________________________________
edk2-devel mailing list
https://lists.sourceforge.net/lists/listinfo/edk2-devel
----------------------------------------------------------------------
-------- Monitor 25 network devices or servers for free with
OpManager!
OpManager is web-based network management software that monitors
network devices and physical & virtual servers, alerts via email & sms
for fault. Monitor 25 devices for free with no restriction. Download
now http://ad.doubleclick.net/ddm/clk/292181274;119417398;o
_______________________________________________
edk2-devel mailing list
https://lists.sourceforge.net/lists/listinfo/edk2-devel
Zhang, Chao B
2015-06-29 01:23:40 UTC
Permalink
The patch is good to me
Reviewed-by: Chao Zhang <***@intel.com>


Thanks & Best regards
Chao Zhang

-----Original Message-----
From: El-Haj-Mahmoud, Samer [mailto:samer.el-haj-***@hp.com]
Sent: Monday, June 29, 2015 12:34 AM
To: Laszlo Ersek; Doman, Jonathan
Cc: edk2-***@lists.sourceforge.net; Zhang, Chao B; El-Haj-Mahmoud, Samer
Subject: RE: [edk2] [PATCH] SecurityPkg: Add MD5 support to Hash2DxeCrypto

Thanks Laszlo. I didn't know the maintainer needs to be CC'd on the patch submission. I will do that on future submissions.

Chao,

Can you review please?

Thanks,


-----Original Message-----
From: Laszlo Ersek [mailto:***@redhat.com]
Sent: Sunday, June 28, 2015 6:57 AM
To: El-Haj-Mahmoud, Samer; Doman, Jonathan
Cc: edk2-***@lists.sourceforge.net; Chao Zhang
Subject: Re: [edk2] [PATCH] SecurityPkg: Add MD5 support to Hash2DxeCrypto
Post by El-Haj-Mahmoud, Samer
If there is no additional feedback on this, can someone please check it in?
I could commit it for you guys, but the Signed-off-by of SecurityPkg's maintainer (Cc'd) is missing.

Is the problem perhaps that he may not have been Cc'd on the initial submission? It's best to consult the Maintainers.txt file, and Cc the package maintainer directly (with Cc: tags in the commit message, to be handled by git-send-email).

Thanks
Laszlo
Post by El-Haj-Mahmoud, Samer
-----Original Message-----
From: El-Haj-Mahmoud, Samer
Sent: Thursday, June 18, 2015 12:27 PM
Subject: Re: [edk2] [PATCH] SecurityPkg: Add MD5 support to
Hash2DxeCrypto
-----Original Message-----
From: Doman, Jonathan
Sent: Friday, June 05, 2015 12:07 PM
Subject: [edk2] [PATCH] SecurityPkg: Add MD5 support to Hash2DxeCrypto
MD5 is part of the HASH2 protocol and it's trivial to support.
Contributed-under: TianoCore Contribution Agreement 1.0
---
SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.c | 2 ++
SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.inf | 4 +++-
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.c
b/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.c
index 92cda36..114ba5e 100644
--- a/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.c
+++ b/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.c
@@ -1,6 +1,7 @@
This module implements Hash2 Protocol.
+ (C) Copyright 2015 Hewlett-Packard Development Company, L.P.<BR>
Copyright (c) 2015, Intel Corporation. All rights reserved.<BR> This program and the accompanying materials are licensed and made available under the terms and conditions of the BSD License that accompanies this distribution.
@@ -125,6 +126,7 @@ typedef struct {
} EFI_HASH_INFO;
EFI_HASH_INFO mHashInfo[] = {
+ {&gEfiHashAlgorithmMD5Guid, sizeof(EFI_MD5_HASH2), Md5GetContextSize, Md5Init, Md5Update, Md5Final },
{&gEfiHashAlgorithmSha1Guid, sizeof(EFI_SHA1_HASH2), Sha1GetContextSize, Sha1Init, Sha1Update, Sha1Final },
{&gEfiHashAlgorithmSha256Guid, sizeof(EFI_SHA256_HASH2), Sha256GetContextSize, Sha256Init, Sha256Update, Sha256Final },
{&gEfiHashAlgorithmSha384Guid, sizeof(EFI_SHA384_HASH2),
Sha384GetContextSize, Sha384Init, Sha384Update, Sha384Final }, diff
--git a/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.inf
b/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.inf
index 1dce002..a631cfb 100644
--- a/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.inf
+++ b/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.inf
@@ -3,6 +3,7 @@
#
# This module will use EDKII crypto libary to HASH2 protocol.
#
+# (C) Copyright 2015 Hewlett-Packard Development Company, L.P.<BR>
UefiLib
[Guids]
+ gEfiHashAlgorithmMD5Guid ## CONSUMES ## GUID
gEfiHashAlgorithmSha1Guid ## CONSUMES ## GUID
gEfiHashAlgorithmSha256Guid ## CONSUMES ## GUID
gEfiHashAlgorithmSha384Guid ## CONSUMES ## GUID
@@ -59,4 +61,4 @@
gEfiHash2ServiceBindingProtocolGuid ## PRODUCES
[UserExtensions.TianoCore."ExtraFiles"]
- Hash2DxeCryptoExtra.uni
\ No newline at end of file
+ Hash2DxeCryptoExtra.uni
--
2.4.2
----------------------------------------------------------------------
-------- _______________________________________________
edk2-devel mailing list
https://lists.sourceforge.net/lists/listinfo/edk2-devel
----------------------------------------------------------------------
-------- _______________________________________________
edk2-devel mailing list
https://lists.sourceforge.net/lists/listinfo/edk2-devel
----------------------------------------------------------------------
-------- Monitor 25 network devices or servers for free with
OpManager!
OpManager is web-based network management software that monitors
network devices and physical & virtual servers, alerts via email & sms
for fault. Monitor 25 devices for free with no restriction. Download
now http://ad.doubleclick.net/ddm/clk/292181274;119417398;o
_______________________________________________
edk2-devel mailing list
https://lists.sourceforge.net/lists/listinfo/edk2-devel
Loading...