[edk2] [PATCH] Fix type cast of ~0 in CheckSignatureListFormat: SigHeaderSize is UINT32

[Bruce Cran]

---
SecurityPkg/VariableAuthenticated/RuntimeDxe/AuthService.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/SecurityPkg/VariableAuthenticated/RuntimeDxe/AuthService.c b/SecurityPkg/VariableAuthenticated/RuntimeDxe/AuthService.c
index 566c5e2..885b916 100644
--- a/SecurityPkg/VariableAuthenticated/RuntimeDxe/AuthService.c
+++ b/SecurityPkg/VariableAuthenticated/RuntimeDxe/AuthService.c
@@ -949,7 +949,7 @@ CheckSignatureListFormat(
(SigList->SignatureSize - sizeof (EFI_GUID)) != mSupportSigItem[Index].SigDataSize) {
return EFI_INVALID_PARAMETER;
}
- if (mSupportSigItem[Index].SigHeaderSize != ((UINTN) ~0) &&
+ if (mSupportSigItem[Index].SigHeaderSize != ((UINT32) ~0) &&
SigList->SignatureHeaderSize != mSupportSigItem[Index].SigHeaderSize) {
return EFI_INVALID_PARAMETER;
}

[Bruce Cran]

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Bruce Cran <***@cran.org.uk>
---
SecurityPkg/VariableAuthenticated/RuntimeDxe/AuthService.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/SecurityPkg/VariableAuthenticated/RuntimeDxe/AuthService.c b/SecurityPkg/VariableAuthenticated/RuntimeDxe/AuthService.c
index 566c5e2..885b916 100644
--- a/SecurityPkg/VariableAuthenticated/RuntimeDxe/AuthService.c
+++ b/SecurityPkg/VariableAuthenticated/RuntimeDxe/AuthService.c
@@ -949,7 +949,7 @@ CheckSignatureListFormat(
(SigList->SignatureSize - sizeof (EFI_GUID)) != mSupportSigItem[Index].SigDataSize) {
return EFI_INVALID_PARAMETER;
}
- if (mSupportSigItem[Index].SigHeaderSize != ((UINTN) ~0) &&
+ if (mSupportSigItem[Index].SigHeaderSize != ((UINT32) ~0) &&
SigList->SignatureHeaderSize != mSupportSigItem[Index].SigHeaderSize) {
return EFI_INVALID_PARAMETER;
}

[Zhang, Chao B]

Bruce:
The patch is good
Reviewed-by： Chao Zhang <***@intel.com>





Thanks & Best regards
Chao Zhang

-----Original Message-----
From: Bruce Cran [mailto:***@cran.org.uk]
Sent: Tuesday, July 07, 2015 10:22 AM
To: Zhang, Chao B; edk2-***@lists.sourceforge.net
Cc: Bruce Cran
Subject: [PATCH] Fix type cast of ~0 in CheckSignatureListFormat: SigHeaderSize is UINT32

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Bruce Cran <***@cran.org.uk>
---
SecurityPkg/VariableAuthenticated/RuntimeDxe/AuthService.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/SecurityPkg/VariableAuthenticated/RuntimeDxe/AuthService.c b/SecurityPkg/VariableAuthenticated/RuntimeDxe/AuthService.c
index 566c5e2..885b916 100644
--- a/SecurityPkg/VariableAuthenticated/RuntimeDxe/AuthService.c
+++ b/SecurityPkg/VariableAuthenticated/RuntimeDxe/AuthService.c
@@ -949,7 +949,7 @@ CheckSignatureListFormat(
(SigList->SignatureSize - sizeof (EFI_GUID)) != mSupportSigItem[Index].SigDataSize) {
return EFI_INVALID_PARAMETER;
}
- if (mSupportSigItem[Index].SigHeaderSize != ((UINTN) ~0) &&
+ if (mSupportSigItem[Index].SigHeaderSize != ((UINT32) ~0) &&
SigList->SignatureHeaderSize != mSupportSigItem[Index].SigHeaderSize) {
return EFI_INVALID_PARAMETER;
}
--
2.4.5

[Bruce Cran]

Post by Bruce Cran
- if (mSupportSigItem[Index].SigHeaderSize != ((UINTN) ~0) &&
+ if (mSupportSigItem[Index].SigHeaderSize != ((UINT32) ~0) &&

Sorry, please ignore this - I forgot to add the Contributed-under and Signed-off-by headers. I've re-sent it with the correct message.