[edk2] Trivial patch process?

[Jordan Justen]

Fork a new thread from the "BaseTools/GCC: allow unused but set
variables" thread...

What about a lower bar for committing build break fixes? What if we
said that compiler warning fixes could be committed by any package
maintainer for any package as long as it is an obvious trivial fix and
it has at least one r-b?

That sounds pretty good to me!

I think qemu has a 'trivial' patch process. I can't remember the
details, but it may involve just Cc'ing the list with a different

http://wiki.qemu.org/Contribute/TrivialPatches

I see they have a separate email list. I prefer to leverage the
edk2-devel list but use the alternate name field in the Cc. I've seen
another project use the main email list address, but alter the name to
ping stable branches.

So, for example, we could also consider:
Cc: UDK2014.SP1 <edk2-***@lists.sourceforge.net>

These can still be searched for, but don't require the hassle of a
separate email list. :)

Anyway, I don't really support this build flag change, but I suppose
it could be acceptable for RELEASE builds.

I think Ard abandoned the idea on seeing Olivier's followup, and I did
the same when I saw Bill's answer.
Your idea about streamlining the current fixup process is a good one;
let's adopt it. Does it need to be codified somewhere (Maintainers.txt,
Contributions.txt, ...)?

I would say Maintainers.txt since it documents email addresses.
However, it might also want to list to a web page that explains it in
more detail.

I think we should hold off on it until we move to the new email list,
but maybe we can figure out a plan that sounds reasonable now.

-Jordan

[Laszlo Ersek]

Post by Jordan Justen
Fork a new thread from the "BaseTools/GCC: allow unused but set
variables" thread...

What about a lower bar for committing build break fixes? What if we
said that compiler warning fixes could be committed by any package
maintainer for any package as long as it is an obvious trivial fix and
it has at least one r-b?

That sounds pretty good to me!

I think qemu has a 'trivial' patch process. I can't remember the
details, but it may involve just Cc'ing the list with a different

http://wiki.qemu.org/Contribute/TrivialPatches

I see they have a separate email list. I prefer to leverage the
edk2-devel list but use the alternate name field in the Cc. I've seen
another project use the main email list address, but alter the name to
ping stable branches.

Smart! "Cc: UDK2014.SP1" would mean "stable"; "Cc: edk2-trivial" would
mean the cross-maintainer commit stuff you described earlier (at the top
in the context).

Post by Jordan Justen
These can still be searched for, but don't require the hassle of a
separate email list. :)

Anyway, I don't really support this build flag change, but I suppose
it could be acceptable for RELEASE builds.

I think Ard abandoned the idea on seeing Olivier's followup, and I did
the same when I saw Bill's answer.
Your idea about streamlining the current fixup process is a good one;
let's adopt it. Does it need to be codified somewhere (Maintainers.txt,
Contributions.txt, ...)?

I would say Maintainers.txt since it documents email addresses.
However, it might also want to list to a web page that explains it in
more detail.
I think we should hold off on it until we move to the new email list,
but maybe we can figure out a plan that sounds reasonable now.

Your plan sounds cool to me. If you write up the Maintainers.txt change
and the new (small) wiki article later on, and I'll gladly nod! :)

Thanks!
Laszlo

Post by Jordan Justen
-Jordan