[edk2] [patch 1/2] NetworkPkg: Check whether the iSCSI initiator name is null.

[Zhang, Lubo]

Popup a warning if iSCSI initiator name is null before attempt configure.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Zhang Lubo <***@intel.com>
Signed-off-by: Zhang, Lubo <***@intel.com>
---
NetworkPkg/IScsiDxe/IScsiConfig.c | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)

diff --git a/NetworkPkg/IScsiDxe/IScsiConfig.c b/NetworkPkg/IScsiDxe/IScsiConfig.c
index c6b48c6..591b522 100644
--- a/NetworkPkg/IScsiDxe/IScsiConfig.c
+++ b/NetworkPkg/IScsiDxe/IScsiConfig.c
@@ -2158,10 +2158,29 @@ IScsiFormCallback (
CopyMem (&OldIfrNvData, IfrNvData, BufferSize);

if (Action == EFI_BROWSER_ACTION_CHANGING) {
switch (QuestionId) {
case KEY_ADD_ATTEMPT:
+ //
+ // Check whether iSCSI initiator name is configured already.
+ //
+ mPrivate->InitiatorNameLength = ISCSI_NAME_MAX_SIZE;
+ Status = gIScsiInitiatorName.Get (
+ &gIScsiInitiatorName,
+ &mPrivate->InitiatorNameLength,
+ mPrivate->InitiatorName
+ );
+ if (EFI_ERROR (Status)) {
+ CreatePopUp (
+ EFI_LIGHTGRAY | EFI_BACKGROUND_BLUE,
+ &Key,
+ L"Error: please configure iSCSI initiator name first!",
+ NULL
+ );
+ break;
+ }
+
Status = IScsiConfigAddAttempt ();
break;

case KEY_DELETE_ATTEMPT:
CopyMem (

[Ye, Ting]

Please update the Copyright to 2015. Others are good to me.
Reviewed-by: Ye Ting <***@intel.com>


Best Regards,
Ting
-----Original Message-----
From: Zhang
Sent: Friday, June 26, 2015 4:11 PM
To: edk2-***@lists.sourceforge.net
Subject: [edk2] [patch 1/2] NetworkPkg: Check whether the iSCSI initiator name is null.

Popup a warning if iSCSI initiator name is null before attempt configure.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Zhang Lubo <***@intel.com>
Signed-off-by: Zhang, Lubo <***@intel.com>
---
NetworkPkg/IScsiDxe/IScsiConfig.c | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)

diff --git a/NetworkPkg/IScsiDxe/IScsiConfig.c b/NetworkPkg/IScsiDxe/IScsiConfig.c
index c6b48c6..591b522 100644
--- a/NetworkPkg/IScsiDxe/IScsiConfig.c
+++ b/NetworkPkg/IScsiDxe/IScsiConfig.c
@@ -2158,10 +2158,29 @@ IScsiFormCallback (
CopyMem (&OldIfrNvData, IfrNvData, BufferSize);

if (Action == EFI_BROWSER_ACTION_CHANGING) {
switch (QuestionId) {
case KEY_ADD_ATTEMPT:
+ //
+ // Check whether iSCSI initiator name is configured already.
+ //
+ mPrivate->InitiatorNameLength = ISCSI_NAME_MAX_SIZE;
+ Status = gIScsiInitiatorName.Get (
+ &gIScsiInitiatorName,
+ &mPrivate->InitiatorNameLength,
+ mPrivate->InitiatorName
+ );
+ if (EFI_ERROR (Status)) {
+ CreatePopUp (
+ EFI_LIGHTGRAY | EFI_BACKGROUND_BLUE,
+ &Key,
+ L"Error: please configure iSCSI initiator name first!",
+ NULL
+ );
+ break;
+ }
+
Status = IScsiConfigAddAttempt ();
break;

case KEY_DELETE_ATTEMPT:
CopyMem (
--
1.9.5.msysgit.1



------------------------------------------------------------------------------
Monitor 25 network devices or servers for free with OpManager!
OpManager is web-based network management software that monitors
network devices and physical & virtual servers, alerts via email & sms
for fault. Monitor 25 devices for free with no restriction. Download now
http://ad.doubleclick.net/ddm/clk/292181274;119417398;o
_______________________________________________
edk2-devel mailing list
edk2-***@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

[Zhang, Lubo]

OK, I will follow the step.

Regards
Lubo

-----Original Message-----
From: Ye, Ting [mailto:***@intel.com]
Sent: Friday, June 26, 2015 4:25 PM
To: edk2-***@lists.sourceforge.net
Subject: Re: [edk2] [patch 1/2] NetworkPkg: Check whether the iSCSI initiator name is null.

Please update the Copyright to 2015. Others are good to me.
Reviewed-by: Ye Ting <***@intel.com>


Best Regards,
Ting
-----Original Message-----
From: Zhang
Sent: Friday, June 26, 2015 4:11 PM
To: edk2-***@lists.sourceforge.net
Subject: [edk2] [patch 1/2] NetworkPkg: Check whether the iSCSI initiator name is null.

Popup a warning if iSCSI initiator name is null before attempt configure.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Zhang Lubo <***@intel.com>
Signed-off-by: Zhang, Lubo <***@intel.com>
---
NetworkPkg/IScsiDxe/IScsiConfig.c | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)

diff --git a/NetworkPkg/IScsiDxe/IScsiConfig.c b/NetworkPkg/IScsiDxe/IScsiConfig.c
index c6b48c6..591b522 100644
--- a/NetworkPkg/IScsiDxe/IScsiConfig.c
+++ b/NetworkPkg/IScsiDxe/IScsiConfig.c
@@ -2158,10 +2158,29 @@ IScsiFormCallback (
CopyMem (&OldIfrNvData, IfrNvData, BufferSize);

if (Action == EFI_BROWSER_ACTION_CHANGING) {
switch (QuestionId) {
case KEY_ADD_ATTEMPT:
+ //
+ // Check whether iSCSI initiator name is configured already.
+ //
+ mPrivate->InitiatorNameLength = ISCSI_NAME_MAX_SIZE;
+ Status = gIScsiInitiatorName.Get (
+ &gIScsiInitiatorName,
+ &mPrivate->InitiatorNameLength,
+ mPrivate->InitiatorName
+ );
+ if (EFI_ERROR (Status)) {
+ CreatePopUp (
+ EFI_LIGHTGRAY | EFI_BACKGROUND_BLUE,
+ &Key,
+ L"Error: please configure iSCSI initiator name first!",
+ NULL
+ );
+ break;
+ }
+
Status = IScsiConfigAddAttempt ();
break;

case KEY_DELETE_ATTEMPT:
CopyMem (
--
1.9.5.msysgit.1



------------------------------------------------------------------------------
Monitor 25 network devices or servers for free with OpManager!
OpManager is web-based network management software that monitors
network devices and physical & virtual servers, alerts via email & sms
for fault. Monitor 25 devices for free with no restriction. Download now
http://ad.doubleclick.net/ddm/clk/292181274;119417398;o
_______________________________________________
edk2-devel mailing list
edk2-***@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

------------------------------------------------------------------------------
Monitor 25 network devices or servers for free with OpManager!
OpManager is web-based network management software that monitors
network devices and physical & virtual servers, alerts via email & sms
for fault. Monitor 25 devices for free with no restriction. Download now
http://ad.doubleclick.net/ddm/clk/292181274;119417398;o
_______________________________________________
edk2-devel mailing list
edk2-***@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel