Discussion:
[edk2] SVN r17714 broke the Coreboot build
Laszlo Ersek
2015-06-26 12:21:37 UTC
Permalink
The commit with subject

CorebootModulePkg: Get power management register addresses.

modified the declaration of the CbParseFadtInfo(), in file
"CorebootModulePkg/Include/Library/CbParseLib.h", and it also updated
the call site.

But the commit didn't update the definition of that function, in
"CorebootModulePkg/Library/CbParseLib/CbParseLib.c". This breaks the build.

The change had probably been made locally, but not added to the patch
when committing.

Laszlo
Dong, Guo
2015-07-01 09:49:36 UTC
Permalink
Laszlo,

Thanks for reminder. The missing code was checked in @17791.

Thanks,
Guo

-----Original Message-----
From: Laszlo Ersek [mailto:***@redhat.com]
Sent: Friday, June 26, 2015 8:22 PM
To: Dong, Guo
Cc: edk2-devel list; Gerd Hoffmann (GMail address)
Subject: SVN r17714 broke the Coreboot build

The commit with subject

CorebootModulePkg: Get power management register addresses.

modified the declaration of the CbParseFadtInfo(), in file "CorebootModulePkg/Include/Library/CbParseLib.h", and it also updated the call site.

But the commit didn't update the definition of that function, in "CorebootModulePkg/Library/CbParseLib/CbParseLib.c". This breaks the build.

The change had probably been made locally, but not added to the patch when committing.

Laszlo

Loading...