Discussion:
[edk2] [PATCH] MdeModulePkg AcpiTableDxe: Non-Boolean comparisons should use a compare operator.
Star Zeng
2015-06-19 07:55:58 UTC
Permalink
Cc: Shumin Qiu <***@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng <***@intel.com>
---
MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableProtocol.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableProtocol.c b/MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableProtocol.c
index d016f34..1569de0 100644
--- a/MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableProtocol.c
+++ b/MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableProtocol.c
@@ -169,7 +169,7 @@ PublishTables (
AcpiTableInstance->TablesInstalled1 = TRUE;
}

- if ((Version & ACPI_TABLE_VERSION_GTE_2_0) &&
+ if (((Version & ACPI_TABLE_VERSION_GTE_2_0) != 0) &&
!AcpiTableInstance->TablesInstalled3) {
Status = gBS->InstallConfigurationTable (&gEfiAcpiTableGuid, AcpiTableInstance->Rsdp3);
if (EFI_ERROR (Status)) {
--
1.9.5.msysgit.0


------------------------------------------------------------------------------
Qiu, Shumin
2015-06-19 08:05:25 UTC
Permalink
Reviewed-by: Qiu Shumin <***@intel.com>

-----Original Message-----
From: Zeng, Star
Sent: Friday, June 19, 2015 3:56 PM
To: edk2-***@lists.sourceforge.net
Cc: Qiu, Shumin
Subject: [PATCH] MdeModulePkg AcpiTableDxe: Non-Boolean comparisons should use a compare operator.

Cc: Shumin Qiu <***@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng <***@intel.com>
---
MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableProtocol.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableProtocol.c b/MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableProtocol.c
index d016f34..1569de0 100644
--- a/MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableProtocol.c
+++ b/MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableProtocol.c
@@ -169,7 +169,7 @@ PublishTables (
AcpiTableInstance->TablesInstalled1 = TRUE;
}

- if ((Version & ACPI_TABLE_VERSION_GTE_2_0) &&
+ if (((Version & ACPI_TABLE_VERSION_GTE_2_0) != 0) &&
!AcpiTableInstance->TablesInstalled3) {
Status = gBS->InstallConfigurationTable (&gEfiAcpiTableGuid, AcpiTableInstance->Rsdp3);
if (EFI_ERROR (Status)) {
--
1.9.5.msysgit.0


------------------------------------------------------------------------------
Loading...