[edk2] [PATCH] OvmfPkg: Fix the build.sh shebang line to avoid depending on location of bash

[Bruce Cran]

The bash binary can be in various locations depending on the system: on Linux
it's in /bin while on BSD it's normally in /usr/local/bin. However, the
env binary is almost always in /usr/bin and so can be used to find and start
the shell.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Bruce Cran <***@cran.org.uk>
---
OvmfPkg/build.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh
index b549ab5..b132d63 100755
--- a/OvmfPkg/build.sh
+++ b/OvmfPkg/build.sh
@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
#
# Copyright (c) 2008 - 2009, Apple Inc. All rights reserved.<BR>
# Copyright (c) 2010 - 2014, Intel Corporation. All rights reserved.<BR>

[Jordan Justen]

Post by Bruce Cran
The bash binary can be in various locations depending on the system: on Linux
it's in /bin while on BSD it's normally in /usr/local/bin. However, the
env binary is almost always in /usr/bin and so can be used to find and start
the shell.
Contributed-under: TianoCore Contribution Agreement 1.0
---
OvmfPkg/build.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh
index b549ab5..b132d63 100755
--- a/OvmfPkg/build.sh
+++ b/OvmfPkg/build.sh
@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
#
# Copyright (c) 2008 - 2009, Apple Inc. All rights reserved.<BR>
# Copyright (c) 2010 - 2014, Intel Corporation. All rights reserved.<BR>
--
2.4.5

[Bruce Cran]

Could it be committed to the UDK2014.SP1 branch as well as master, please?

[Jordan Justen]

Post by Bruce Cran
Could it be committed to the UDK2014.SP1 branch as well as master, please?

Bruce,

I'm not sure of the update process for that branch, but it sure seems
like a non-risky patch to cherry-pick.

Hot, Liming,

Do either of you know who owns the UDK2014.SP1 branch?

Thanks,

-Jordan

[Wu, Hao A]

The commit was synced to UDK2014.SP1 branch @ r17892.

Best Regards,
Hao Wu

-----Original Message-----
Sent: Thursday, July 09, 2015 4:14 AM
To: Bruce Cran; Tian, Hot; Gao, Liming
Subject: Re: [edk2] [PATCH] OvmfPkg: Fix the build.sh shebang line to avoid
depending on location of bash

Post by Bruce Cran
Could it be committed to the UDK2014.SP1 branch as well as master, please?

Bruce,
I'm not sure of the update process for that branch, but it sure seems
like a non-risky patch to cherry-pick.
Hot, Liming,
Do either of you know who owns the UDK2014.SP1 branch?
Thanks,
-Jordan
------------------------------------------------------------------------------
Don't Limit Your Business. Reach for the Cloud.
GigeNET's Cloud Solutions provide you with the tools and support that
you need to offload your IT needs and focus on growing your business.
Configured For All Businesses. Start Your Cloud Today.
https://www.gigenetcloud.com/
_______________________________________________
edk2-devel mailing list
https://lists.sourceforge.net/lists/listinfo/edk2-devel

[Gao, Liming]

Jordan:
Wu, Hao has help synced it to UDK2014.SP1. He is the maintainer of this branch.

Thanks
Liming
-----Original Message-----
From: Justen, Jordan L
Sent: Thursday, July 09, 2015 4:14 AM
To: Bruce Cran; Tian, Hot; Gao, Liming
Cc: Laszlo Ersek; edk2-***@lists.sourceforge.net
Subject: Re: [PATCH] OvmfPkg: Fix the build.sh shebang line to avoid depending on location of bash

Post by Bruce Cran
Could it be committed to the UDK2014.SP1 branch as well as master, please?

Bruce,

I'm not sure of the update process for that branch, but it sure seems like a non-risky patch to cherry-pick.

Hot, Liming,

Do either of you know who owns the UDK2014.SP1 branch?

Thanks,

-Jordan