Discussion:
[edk2] [PATCH] MdeModulePkg: Refine the comments format for PropertiesTable.
Qiu Shumin
2015-06-09 03:12:45 UTC
Permalink
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu Shumin <***@intel.com>
---
MdeModulePkg/Core/Dxe/Misc/PropertiesTable.c | 5 +++--
.../PropertiesTableAttributesDxe/PropertiesTableAttributesDxe.c | 2 +-
.../PropertiesTableAttributesDxe/PropertiesTableAttributesDxe.inf | 1 -
3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/MdeModulePkg/Core/Dxe/Misc/PropertiesTable.c b/MdeModulePkg/Core/Dxe/Misc/PropertiesTable.c
index 897f970..813ca48 100644
--- a/MdeModulePkg/Core/Dxe/Misc/PropertiesTable.c
+++ b/MdeModulePkg/Core/Dxe/Misc/PropertiesTable.c
@@ -543,6 +543,7 @@ GetMaxSplitRecordCount (
The caller gurantee the buffer size be 1 +
(SplitRecordCount * DescriptorSize) calculated
below.
+ @param MaxSplitRecordCount The max number of splitted entries
@param DescriptorSize Size, in bytes, of an individual EFI_MEMORY_DESCRIPTOR.

@retval 0 no entry is splitted.
@@ -934,7 +935,7 @@ SortImageRecordCodeSection (
}

/**
- Check if code section in image record is valid
+ Check if code section in image record is valid.

@param ImageRecord image record to be checked

@@ -1066,7 +1067,7 @@ SortImageRecord (
}

/**
- Dump image record
+ Dump image record.
**/
VOID
DumpImageRecord (
diff --git a/MdeModulePkg/Universal/PropertiesTableAttributesDxe/PropertiesTableAttributesDxe.c b/MdeModulePkg/Universal/PropertiesTableAttributesDxe/PropertiesTableAttributesDxe.c
index 12e4566..8d17a03 100644
--- a/MdeModulePkg/Universal/PropertiesTableAttributesDxe/PropertiesTableAttributesDxe.c
+++ b/MdeModulePkg/Universal/PropertiesTableAttributesDxe/PropertiesTableAttributesDxe.c
@@ -1,4 +1,4 @@
-/**@file
+/** @file
This module sets default policy for attributes of EfiACPIMemoryNVS and EfiReservedMemoryType.

This module sets EFI_MEMORY_XP for attributes of EfiACPIMemoryNVS and EfiReservedMemoryType
diff --git a/MdeModulePkg/Universal/PropertiesTableAttributesDxe/PropertiesTableAttributesDxe.inf b/MdeModulePkg/Universal/PropertiesTableAttributesDxe/PropertiesTableAttributesDxe.inf
index 7b3025a..3f699f6 100644
--- a/MdeModulePkg/Universal/PropertiesTableAttributesDxe/PropertiesTableAttributesDxe.inf
+++ b/MdeModulePkg/Universal/PropertiesTableAttributesDxe/PropertiesTableAttributesDxe.inf
@@ -1,5 +1,4 @@
## @file
-#
# This module sets default policy for attributes of EfiACPIMemoryNVS and EfiReservedMemoryType.
#
# This module sets EFI_MEMORY_XP for attributes of EfiACPIMemoryNVS and EfiReservedMemoryType
--
1.9.5.msysgit.1



------------------------------------------------------------------------------
Yao, Jiewen
2015-06-09 03:20:59 UTC
Permalink
Thanks for fixing it.

Reviewed-by: Jiewen Yao <***@intel.com>

-----Original Message-----
From: Qiu, Shumin
Sent: Tuesday, June 09, 2015 11:13 AM
To: edk2-***@lists.sourceforge.net
Cc: Yao, Jiewen
Subject: [PATCH] MdeModulePkg: Refine the comments format for PropertiesTable.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu Shumin <***@intel.com>
---
MdeModulePkg/Core/Dxe/Misc/PropertiesTable.c | 5 +++--
.../PropertiesTableAttributesDxe/PropertiesTableAttributesDxe.c | 2 +-
.../PropertiesTableAttributesDxe/PropertiesTableAttributesDxe.inf | 1 -
3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/MdeModulePkg/Core/Dxe/Misc/PropertiesTable.c b/MdeModulePkg/Core/Dxe/Misc/PropertiesTable.c
index 897f970..813ca48 100644
--- a/MdeModulePkg/Core/Dxe/Misc/PropertiesTable.c
+++ b/MdeModulePkg/Core/Dxe/Misc/PropertiesTable.c
@@ -543,6 +543,7 @@ GetMaxSplitRecordCount (
The caller gurantee the buffer size be 1 +
(SplitRecordCount * DescriptorSize) calculated
below.
+ @param MaxSplitRecordCount The max number of splitted entries
@param DescriptorSize Size, in bytes, of an individual EFI_MEMORY_DESCRIPTOR.

@retval 0 no entry is splitted.
@@ -934,7 +935,7 @@ SortImageRecordCodeSection ( }

/**
- Check if code section in image record is valid
+ Check if code section in image record is valid.

@param ImageRecord image record to be checked

@@ -1066,7 +1067,7 @@ SortImageRecord (
}

/**
- Dump image record
+ Dump image record.
**/
VOID
DumpImageRecord (
diff --git a/MdeModulePkg/Universal/PropertiesTableAttributesDxe/PropertiesTableAttributesDxe.c b/MdeModulePkg/Universal/PropertiesTableAttributesDxe/PropertiesTableAttributesDxe.c
index 12e4566..8d17a03 100644
--- a/MdeModulePkg/Universal/PropertiesTableAttributesDxe/PropertiesTableAttributesDxe.c
+++ b/MdeModulePkg/Universal/PropertiesTableAttributesDxe/PropertiesTabl
+++ eAttributesDxe.c
@@ -1,4 +1,4 @@
-/**@file
+/** @file
This module sets default policy for attributes of EfiACPIMemoryNVS and EfiReservedMemoryType.

This module sets EFI_MEMORY_XP for attributes of EfiACPIMemoryNVS and EfiReservedMemoryType diff --git a/MdeModulePkg/Universal/PropertiesTableAttributesDxe/PropertiesTableAttributesDxe.inf b/MdeModulePkg/Universal/PropertiesTableAttributesDxe/PropertiesTableAttributesDxe.inf
index 7b3025a..3f699f6 100644
--- a/MdeModulePkg/Universal/PropertiesTableAttributesDxe/PropertiesTableAttributesDxe.inf
+++ b/MdeModulePkg/Universal/PropertiesTableAttributesDxe/PropertiesTabl
+++ eAttributesDxe.inf
@@ -1,5 +1,4 @@
## @file
-#
# This module sets default policy for attributes of EfiACPIMemoryNVS and EfiReservedMemoryType.
#
# This module sets EFI_MEMORY_XP for attributes of EfiACPIMemoryNVS and EfiReservedMemoryType
--
1.9.5.msysgit.1



------------------------------------------------------------------------------
Loading...