Discussion:
[edk2] [PATCH] Add virtio-vga support
Gerd Hoffmann
2015-06-23 12:36:10 UTC
Permalink
The vga compatibility part of virtio-vga is identical to the qemu
standard vga, so supporting that is as easy as adding the PCI ID
to the list.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Gerd Hoffmann <***@redhat.com>
---
OvmfPkg/QemuVideoDxe/Driver.c | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/OvmfPkg/QemuVideoDxe/Driver.c b/OvmfPkg/QemuVideoDxe/Driver.c
index c74d1a2..8d962b4 100644
--- a/OvmfPkg/QemuVideoDxe/Driver.c
+++ b/OvmfPkg/QemuVideoDxe/Driver.c
@@ -53,6 +53,11 @@ QEMU_VIDEO_CARD gQemuVideoCardList[] = {
QEMU_VIDEO_BOCHS,
L"QEMU QXL VGA"
},{
+ 0x1af4,
+ 0x1050,
+ QEMU_VIDEO_BOCHS_MMIO,
+ L"QEMU VirtIO VGA"
+ },{
0 /* end of list */
}
};
--
1.8.3.1
Laszlo Ersek
2015-06-23 12:52:51 UTC
Permalink
Post by Gerd Hoffmann
The vga compatibility part of virtio-vga is identical to the qemu
standard vga, so supporting that is as easy as adding the PCI ID
to the list.
Contributed-under: TianoCore Contribution Agreement 1.0
---
OvmfPkg/QemuVideoDxe/Driver.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/OvmfPkg/QemuVideoDxe/Driver.c b/OvmfPkg/QemuVideoDxe/Driver.c
index c74d1a2..8d962b4 100644
--- a/OvmfPkg/QemuVideoDxe/Driver.c
+++ b/OvmfPkg/QemuVideoDxe/Driver.c
@@ -53,6 +53,11 @@ QEMU_VIDEO_CARD gQemuVideoCardList[] = {
QEMU_VIDEO_BOCHS,
L"QEMU QXL VGA"
},{
+ 0x1af4,
+ 0x1050,
+ QEMU_VIDEO_BOCHS_MMIO,
+ L"QEMU VirtIO VGA"
+ },{
0 /* end of list */
}
};
Can you please name the qemu commit (or one of the commits) that adds
the device model?

Plus, the subject should say:

OvmfPkg: QemuVideoDxe: add virtio-vga support

I'll update the commit message for you.

Reviewed-by: Laszlo Ersek <***@redhat.com>

First let's give Jordan a chance to look at this though.

Thanks
Laszlo
Gerd Hoffmann
2015-06-23 13:27:41 UTC
Permalink
Post by Laszlo Ersek
Post by Gerd Hoffmann
The vga compatibility part of virtio-vga is identical to the qemu
standard vga, so supporting that is as easy as adding the PCI ID
to the list.
Contributed-under: TianoCore Contribution Agreement 1.0
---
OvmfPkg/QemuVideoDxe/Driver.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/OvmfPkg/QemuVideoDxe/Driver.c b/OvmfPkg/QemuVideoDxe/Driver.c
index c74d1a2..8d962b4 100644
--- a/OvmfPkg/QemuVideoDxe/Driver.c
+++ b/OvmfPkg/QemuVideoDxe/Driver.c
@@ -53,6 +53,11 @@ QEMU_VIDEO_CARD gQemuVideoCardList[] = {
QEMU_VIDEO_BOCHS,
L"QEMU QXL VGA"
},{
+ 0x1af4,
+ 0x1050,
+ QEMU_VIDEO_BOCHS_MMIO,
+ L"QEMU VirtIO VGA"
+ },{
0 /* end of list */
}
};
Can you please name the qemu commit (or one of the commits) that adds
c5d4dac virtio-vga: add virtio gpu device with vga compatibility

cheers,
Gerd
Jordan Justen
2015-06-23 20:28:56 UTC
Permalink
Post by Laszlo Ersek
Post by Gerd Hoffmann
The vga compatibility part of virtio-vga is identical to the qemu
standard vga, so supporting that is as easy as adding the PCI ID
to the list.
Contributed-under: TianoCore Contribution Agreement 1.0
---
OvmfPkg/QemuVideoDxe/Driver.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/OvmfPkg/QemuVideoDxe/Driver.c b/OvmfPkg/QemuVideoDxe/Driver.c
index c74d1a2..8d962b4 100644
--- a/OvmfPkg/QemuVideoDxe/Driver.c
+++ b/OvmfPkg/QemuVideoDxe/Driver.c
@@ -53,6 +53,11 @@ QEMU_VIDEO_CARD gQemuVideoCardList[] = {
QEMU_VIDEO_BOCHS,
L"QEMU QXL VGA"
},{
+ 0x1af4,
+ 0x1050,
+ QEMU_VIDEO_BOCHS_MMIO,
+ L"QEMU VirtIO VGA"
+ },{
0 /* end of list */
}
};
Can you please name the qemu commit (or one of the commits) that adds
the device model?
OvmfPkg: QemuVideoDxe: add virtio-vga support
I'll update the commit message for you.
First let's give Jordan a chance to look at this though.
Acked-by: Jordan Justen <***@intel.com>
Laszlo Ersek
2015-06-23 20:50:26 UTC
Permalink
Post by Gerd Hoffmann
The vga compatibility part of virtio-vga is identical to the qemu
standard vga, so supporting that is as easy as adding the PCI ID
to the list.
Contributed-under: TianoCore Contribution Agreement 1.0
---
OvmfPkg/QemuVideoDxe/Driver.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/OvmfPkg/QemuVideoDxe/Driver.c b/OvmfPkg/QemuVideoDxe/Driver.c
index c74d1a2..8d962b4 100644
--- a/OvmfPkg/QemuVideoDxe/Driver.c
+++ b/OvmfPkg/QemuVideoDxe/Driver.c
@@ -53,6 +53,11 @@ QEMU_VIDEO_CARD gQemuVideoCardList[] = {
QEMU_VIDEO_BOCHS,
L"QEMU QXL VGA"
},{
+ 0x1af4,
+ 0x1050,
+ QEMU_VIDEO_BOCHS_MMIO,
+ L"QEMU VirtIO VGA"
+ },{
0 /* end of list */
}
};
Committed to SVN as r17690.

Thanks!
Laszlo

Loading...