[edk2] [PATCH] MdeModulePkg/PartitionDxe: Fix media probe

[Olivier Martin]

Dear MdeModulePkg maintainer,

Please find the attached patch that should fix the following issue:

The call in ProbeMediaStatus() to the ReadDisk() function of the
EFI_DISK_IO_PROTOCOL interface implemented in DiskIoDxe/DiskIo.c
crashed in DiskIo2ReadWriteDisk() because of the NULL value of
the destination buffer pointer.

Pass the address of a buffer in the stack instead of a NULL
pointer.

In addition to avoiding the crash, that way, the media probe does not
depend anymore on the way the EFI_DISK_IO_PROTOCOL implementation deals
with a NULL value of the destination buffer pointer as the UEFI
specification does not specify the expected behaviour.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ronald Cron <***@arm.com<mailto:***@arm.com>>
Reviewed-by: Olivier Martin <***@arm.com>

Regards,
Olivier

-- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

ARM Limited, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2557590
ARM Holdings plc, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2548782

[Tian, Feng]

Thanks, Martin

I think it's a bug and our test coverage may be not enough as it doesn't get exposed before.

Will double confirm with Partition owner and get back to you if we have conclusion.

Thanks
Feng

From: Olivier Martin [mailto:***@arm.com]
Sent: Wednesday, April 1, 2015 11:23 PM
To: Tian, Feng
Cc: Ronald Cron; edk2-***@lists.sourceforge.net
Subject: [PATCH] MdeModulePkg/PartitionDxe: Fix media probe

Dear MdeModulePkg maintainer,

Please find the attached patch that should fix the following issue:

The call in ProbeMediaStatus() to the ReadDisk() function of the
EFI_DISK_IO_PROTOCOL interface implemented in DiskIoDxe/DiskIo.c
crashed in DiskIo2ReadWriteDisk() because of the NULL value of
the destination buffer pointer.

Pass the address of a buffer in the stack instead of a NULL
pointer.

In addition to avoiding the crash, that way, the media probe does not
depend anymore on the way the EFI_DISK_IO_PROTOCOL implementation deals
with a NULL value of the destination buffer pointer as the UEFI
specification does not specify the expected behaviour.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ronald Cron <***@arm.com<mailto:***@arm.com>>
Reviewed-by: Olivier Martin <***@arm.com<mailto:***@arm.com>>

Regards,
Olivier

-- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

ARM Limited, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2557590
ARM Holdings plc, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2548782

[Ni, Ruiyu]

Martin,
Please check the attached patch. Can it solve your issue?

Thanks,
Ray

From: Tian, Feng [mailto:***@intel.com]
Sent: Thursday, April 2, 2015 9:37 AM
To: Olivier Martin
Cc: Ronald Cron; edk2-***@lists.sourceforge.net
Subject: Re: [edk2] [PATCH] MdeModulePkg/PartitionDxe: Fix media probe

Thanks, Martin

I think it's a bug and our test coverage may be not enough as it doesn't get exposed before.

Will double confirm with Partition owner and get back to you if we have conclusion.

Thanks
Feng

From: Olivier Martin [mailto:***@arm.com]
Sent: Wednesday, April 1, 2015 11:23 PM
To: Tian, Feng
Cc: Ronald Cron; edk2-***@lists.sourceforge.net<mailto:edk2-***@lists.sourceforge.net>
Subject: [PATCH] MdeModulePkg/PartitionDxe: Fix media probe

Dear MdeModulePkg maintainer,

Please find the attached patch that should fix the following issue:

The call in ProbeMediaStatus() to the ReadDisk() function of the
EFI_DISK_IO_PROTOCOL interface implemented in DiskIoDxe/DiskIo.c
crashed in DiskIo2ReadWriteDisk() because of the NULL value of
the destination buffer pointer.

Pass the address of a buffer in the stack instead of a NULL
pointer.

In addition to avoiding the crash, that way, the media probe does not
depend anymore on the way the EFI_DISK_IO_PROTOCOL implementation deals
with a NULL value of the destination buffer pointer as the UEFI
specification does not specify the expected behaviour.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ronald Cron <***@arm.com<mailto:***@arm.com>>
Reviewed-by: Olivier Martin <***@arm.com<mailto:***@arm.com>>

Regards,
Olivier

-- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

ARM Limited, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2557590
ARM Holdings plc, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2548782

[Olivier Martin]

It is likely your change will not test if there is a present media by reading no byte.
I think Ronald's change (original patch) is better.

From: Ni, Ruiyu [mailto:***@intel.com]
Sent: 02 April 2015 05:33
To: edk2-***@lists.sourceforge.net; Olivier Martin
Cc: Ronald Cron
Subject: RE: [PATCH] MdeModulePkg/PartitionDxe: Fix media probe

Martin,
Please check the attached patch. Can it solve your issue?

Thanks,
Ray

From: Tian, Feng [mailto:***@intel.com]
Sent: Thursday, April 2, 2015 9:37 AM
To: Olivier Martin
Cc: Ronald Cron; edk2-***@lists.sourceforge.net<mailto:edk2-***@lists.sourceforge.net>
Subject: Re: [edk2] [PATCH] MdeModulePkg/PartitionDxe: Fix media probe

Thanks, Martin

I think it's a bug and our test coverage may be not enough as it doesn't get exposed before.

Will double confirm with Partition owner and get back to you if we have conclusion.

Thanks
Feng

From: Olivier Martin [mailto:***@arm.com]
Sent: Wednesday, April 1, 2015 11:23 PM
To: Tian, Feng
Cc: Ronald Cron; edk2-***@lists.sourceforge.net<mailto:edk2-***@lists.sourceforge.net>
Subject: [PATCH] MdeModulePkg/PartitionDxe: Fix media probe

Dear MdeModulePkg maintainer,

Please find the attached patch that should fix the following issue:

The call in ProbeMediaStatus() to the ReadDisk() function of the
EFI_DISK_IO_PROTOCOL interface implemented in DiskIoDxe/DiskIo.c
crashed in DiskIo2ReadWriteDisk() because of the NULL value of
the destination buffer pointer.

Pass the address of a buffer in the stack instead of a NULL
pointer.

In addition to avoiding the crash, that way, the media probe does not
depend anymore on the way the EFI_DISK_IO_PROTOCOL implementation deals
with a NULL value of the destination buffer pointer as the UEFI
specification does not specify the expected behaviour.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ronald Cron <***@arm.com<mailto:***@arm.com>>
Reviewed-by: Olivier Martin <***@arm.com<mailto:***@arm.com>>

Regards,
Olivier

-- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

ARM Limited, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2557590
ARM Holdings plc, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2548782

-- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

ARM Limited, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2557590
ARM Holdings plc, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2548782

[Olivier Martin]

Any update on this patch?

From: Olivier Martin [mailto:***@arm.com]
Sent: 02 April 2015 10:44
To: Ni, Ruiyu; edk2-***@lists.sourceforge.net
Cc: Ronald Cron
Subject: Re: [edk2] [PATCH] MdeModulePkg/PartitionDxe: Fix media probe

It is likely your change will not test if there is a present media by reading no byte.
I think Ronald's change (original patch) is better.

From: Ni, Ruiyu [mailto:***@intel.com]
Sent: 02 April 2015 05:33
To: edk2-***@lists.sourceforge.net<mailto:edk2-***@lists.sourceforge.net>; Olivier Martin
Cc: Ronald Cron
Subject: RE: [PATCH] MdeModulePkg/PartitionDxe: Fix media probe

Martin,
Please check the attached patch. Can it solve your issue?

Thanks,
Ray

From: Tian, Feng [mailto:***@intel.com]
Sent: Thursday, April 2, 2015 9:37 AM
To: Olivier Martin
Cc: Ronald Cron; edk2-***@lists.sourceforge.net<mailto:edk2-***@lists.sourceforge.net>
Subject: Re: [edk2] [PATCH] MdeModulePkg/PartitionDxe: Fix media probe

Thanks, Martin

I think it's a bug and our test coverage may be not enough as it doesn't get exposed before.

Will double confirm with Partition owner and get back to you if we have conclusion.

Thanks
Feng

From: Olivier Martin [mailto:***@arm.com]
Sent: Wednesday, April 1, 2015 11:23 PM
To: Tian, Feng
Cc: Ronald Cron; edk2-***@lists.sourceforge.net<mailto:edk2-***@lists.sourceforge.net>
Subject: [PATCH] MdeModulePkg/PartitionDxe: Fix media probe

Dear MdeModulePkg maintainer,

Please find the attached patch that should fix the following issue:

The call in ProbeMediaStatus() to the ReadDisk() function of the
EFI_DISK_IO_PROTOCOL interface implemented in DiskIoDxe/DiskIo.c
crashed in DiskIo2ReadWriteDisk() because of the NULL value of
the destination buffer pointer.

Pass the address of a buffer in the stack instead of a NULL
pointer.

In addition to avoiding the crash, that way, the media probe does not
depend anymore on the way the EFI_DISK_IO_PROTOCOL implementation deals
with a NULL value of the destination buffer pointer as the UEFI
specification does not specify the expected behaviour.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ronald Cron <***@arm.com<mailto:***@arm.com>>
Reviewed-by: Olivier Martin <***@arm.com<mailto:***@arm.com>>

Regards,
Olivier

-- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

ARM Limited, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2557590
ARM Holdings plc, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2548782

-- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

ARM Limited, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2557590
ARM Holdings plc, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2548782

-- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

ARM Limited, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2557590
ARM Holdings plc, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2548782

[Ni, Ruiyu]

Martin,
I agree that your patch works. Just wanted to figure out a better patch. But I haven't got chance to do the investigation yet.

Thanks,
Ray

From: Olivier Martin [mailto:***@arm.com]
Sent: Tuesday, May 5, 2015 10:46 PM
To: edk2-***@lists.sourceforge.net; Ni, Ruiyu
Cc: Ronald Cron
Subject: RE: [PATCH] MdeModulePkg/PartitionDxe: Fix media probe

Any update on this patch?

From: Olivier Martin [mailto:***@arm.com]
Sent: 02 April 2015 10:44
To: Ni, Ruiyu; edk2-***@lists.sourceforge.net<mailto:edk2-***@lists.sourceforge.net>
Cc: Ronald Cron
Subject: Re: [edk2] [PATCH] MdeModulePkg/PartitionDxe: Fix media probe

It is likely your change will not test if there is a present media by reading no byte.
I think Ronald's change (original patch) is better.

From: Ni, Ruiyu [mailto:***@intel.com]
Sent: 02 April 2015 05:33
To: edk2-***@lists.sourceforge.net<mailto:edk2-***@lists.sourceforge.net>; Olivier Martin
Cc: Ronald Cron
Subject: RE: [PATCH] MdeModulePkg/PartitionDxe: Fix media probe

Martin,
Please check the attached patch. Can it solve your issue?

Thanks,
Ray

From: Tian, Feng [mailto:***@intel.com]
Sent: Thursday, April 2, 2015 9:37 AM
To: Olivier Martin
Cc: Ronald Cron; edk2-***@lists.sourceforge.net<mailto:edk2-***@lists.sourceforge.net>
Subject: Re: [edk2] [PATCH] MdeModulePkg/PartitionDxe: Fix media probe

Thanks, Martin

I think it's a bug and our test coverage may be not enough as it doesn't get exposed before.

Will double confirm with Partition owner and get back to you if we have conclusion.

Thanks
Feng

From: Olivier Martin [mailto:***@arm.com]
Sent: Wednesday, April 1, 2015 11:23 PM
To: Tian, Feng
Cc: Ronald Cron; edk2-***@lists.sourceforge.net<mailto:edk2-***@lists.sourceforge.net>
Subject: [PATCH] MdeModulePkg/PartitionDxe: Fix media probe

Dear MdeModulePkg maintainer,

Please find the attached patch that should fix the following issue:

The call in ProbeMediaStatus() to the ReadDisk() function of the
EFI_DISK_IO_PROTOCOL interface implemented in DiskIoDxe/DiskIo.c
crashed in DiskIo2ReadWriteDisk() because of the NULL value of
the destination buffer pointer.

Pass the address of a buffer in the stack instead of a NULL
pointer.

In addition to avoiding the crash, that way, the media probe does not
depend anymore on the way the EFI_DISK_IO_PROTOCOL implementation deals
with a NULL value of the destination buffer pointer as the UEFI
specification does not specify the expected behaviour.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ronald Cron <***@arm.com<mailto:***@arm.com>>
Reviewed-by: Olivier Martin <***@arm.com<mailto:***@arm.com>>

Regards,
Olivier

-- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

ARM Limited, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2557590
ARM Holdings plc, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2548782

-- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

ARM Limited, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2557590
ARM Holdings plc, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2548782

-- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

ARM Limited, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2557590
ARM Holdings plc, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2548782

[Olivier Martin]

Are you still debating on my simple patch I sent 3 months ago that definitely fixes an issue?

From: Ni, Ruiyu [mailto:***@intel.com]
Sent: 06 May 2015 03:37
To: Olivier Martin; edk2-***@lists.sourceforge.net
Cc: Ronald Cron
Subject: RE: [PATCH] MdeModulePkg/PartitionDxe: Fix media probe

Martin,
I agree that your patch works. Just wanted to figure out a better patch. But I haven't got chance to do the investigation yet.

Thanks,
Ray

From: Olivier Martin [mailto:***@arm.com]
Sent: Tuesday, May 5, 2015 10:46 PM
To: edk2-***@lists.sourceforge.net<mailto:edk2-***@lists.sourceforge.net>; Ni, Ruiyu
Cc: Ronald Cron
Subject: RE: [PATCH] MdeModulePkg/PartitionDxe: Fix media probe

Any update on this patch?

From: Olivier Martin [mailto:***@arm.com]
Sent: 02 April 2015 10:44
To: Ni, Ruiyu; edk2-***@lists.sourceforge.net<mailto:edk2-***@lists.sourceforge.net>
Cc: Ronald Cron
Subject: Re: [edk2] [PATCH] MdeModulePkg/PartitionDxe: Fix media probe

It is likely your change will not test if there is a present media by reading no byte.
I think Ronald's change (original patch) is better.

From: Ni, Ruiyu [mailto:***@intel.com]
Sent: 02 April 2015 05:33
To: edk2-***@lists.sourceforge.net<mailto:edk2-***@lists.sourceforge.net>; Olivier Martin
Cc: Ronald Cron
Subject: RE: [PATCH] MdeModulePkg/PartitionDxe: Fix media probe

Martin,
Please check the attached patch. Can it solve your issue?

Thanks,
Ray

From: Tian, Feng [mailto:***@intel.com]
Sent: Thursday, April 2, 2015 9:37 AM
To: Olivier Martin
Cc: Ronald Cron; edk2-***@lists.sourceforge.net<mailto:edk2-***@lists.sourceforge.net>
Subject: Re: [edk2] [PATCH] MdeModulePkg/PartitionDxe: Fix media probe

Thanks, Martin

I think it's a bug and our test coverage may be not enough as it doesn't get exposed before.

Will double confirm with Partition owner and get back to you if we have conclusion.

Thanks
Feng

From: Olivier Martin [mailto:***@arm.com]
Sent: Wednesday, April 1, 2015 11:23 PM
To: Tian, Feng
Cc: Ronald Cron; edk2-***@lists.sourceforge.net<mailto:edk2-***@lists.sourceforge.net>
Subject: [PATCH] MdeModulePkg/PartitionDxe: Fix media probe

Dear MdeModulePkg maintainer,

Please find the attached patch that should fix the following issue:

The call in ProbeMediaStatus() to the ReadDisk() function of the
EFI_DISK_IO_PROTOCOL interface implemented in DiskIoDxe/DiskIo.c
crashed in DiskIo2ReadWriteDisk() because of the NULL value of
the destination buffer pointer.

Pass the address of a buffer in the stack instead of a NULL
pointer.

In addition to avoiding the crash, that way, the media probe does not
depend anymore on the way the EFI_DISK_IO_PROTOCOL implementation deals
with a NULL value of the destination buffer pointer as the UEFI
specification does not specify the expected behaviour.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ronald Cron <***@arm.com<mailto:***@arm.com>>
Reviewed-by: Olivier Martin <***@arm.com<mailto:***@arm.com>>

Regards,
Olivier

-- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

ARM Limited, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2557590
ARM Holdings plc, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2548782

-- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

ARM Limited, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2557590
ARM Holdings plc, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2548782

-- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

ARM Limited, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2557590
ARM Holdings plc, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2548782

-- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

ARM Limited, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2557590
ARM Holdings plc, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2548782

[Ni, Ruiyu]

Martin,
Please go ahead to check in the patch first. I will send new patch for review later when I have bandwidth to look into this further.
Reviewed-by: Ruiyu Ni <***@intel.com>

Thanks,
Ray

From: Olivier Martin [mailto:***@arm.com]
Sent: Monday, July 6, 2015 10:12 PM
To: Ni, Ruiyu; edk2-***@lists.sourceforge.net
Cc: Ronald Cron
Subject: RE: [PATCH] MdeModulePkg/PartitionDxe: Fix media probe

Are you still debating on my simple patch I sent 3 months ago that definitely fixes an issue?

From: Ni, Ruiyu [mailto:***@intel.com]
Sent: 06 May 2015 03:37
To: Olivier Martin; edk2-***@lists.sourceforge.net<mailto:edk2-***@lists.sourceforge.net>
Cc: Ronald Cron
Subject: RE: [PATCH] MdeModulePkg/PartitionDxe: Fix media probe

Martin,
I agree that your patch works. Just wanted to figure out a better patch. But I haven't got chance to do the investigation yet.

Thanks,
Ray

From: Olivier Martin [mailto:***@arm.com]
Sent: Tuesday, May 5, 2015 10:46 PM
To: edk2-***@lists.sourceforge.net<mailto:edk2-***@lists.sourceforge.net>; Ni, Ruiyu
Cc: Ronald Cron
Subject: RE: [PATCH] MdeModulePkg/PartitionDxe: Fix media probe

Any update on this patch?

From: Olivier Martin [mailto:***@arm.com]
Sent: 02 April 2015 10:44
To: Ni, Ruiyu; edk2-***@lists.sourceforge.net<mailto:edk2-***@lists.sourceforge.net>
Cc: Ronald Cron
Subject: Re: [edk2] [PATCH] MdeModulePkg/PartitionDxe: Fix media probe

It is likely your change will not test if there is a present media by reading no byte.
I think Ronald's change (original patch) is better.

From: Ni, Ruiyu [mailto:***@intel.com]
Sent: 02 April 2015 05:33
To: edk2-***@lists.sourceforge.net<mailto:edk2-***@lists.sourceforge.net>; Olivier Martin
Cc: Ronald Cron
Subject: RE: [PATCH] MdeModulePkg/PartitionDxe: Fix media probe

Martin,
Please check the attached patch. Can it solve your issue?

Thanks,
Ray

From: Tian, Feng [mailto:***@intel.com]
Sent: Thursday, April 2, 2015 9:37 AM
To: Olivier Martin
Cc: Ronald Cron; edk2-***@lists.sourceforge.net<mailto:edk2-***@lists.sourceforge.net>
Subject: Re: [edk2] [PATCH] MdeModulePkg/PartitionDxe: Fix media probe

Thanks, Martin

I think it's a bug and our test coverage may be not enough as it doesn't get exposed before.

Will double confirm with Partition owner and get back to you if we have conclusion.

Thanks
Feng

From: Olivier Martin [mailto:***@arm.com]
Sent: Wednesday, April 1, 2015 11:23 PM
To: Tian, Feng
Cc: Ronald Cron; edk2-***@lists.sourceforge.net<mailto:edk2-***@lists.sourceforge.net>
Subject: [PATCH] MdeModulePkg/PartitionDxe: Fix media probe

Dear MdeModulePkg maintainer,

Please find the attached patch that should fix the following issue:

The call in ProbeMediaStatus() to the ReadDisk() function of the
EFI_DISK_IO_PROTOCOL interface implemented in DiskIoDxe/DiskIo.c
crashed in DiskIo2ReadWriteDisk() because of the NULL value of
the destination buffer pointer.

Pass the address of a buffer in the stack instead of a NULL
pointer.

In addition to avoiding the crash, that way, the media probe does not
depend anymore on the way the EFI_DISK_IO_PROTOCOL implementation deals
with a NULL value of the destination buffer pointer as the UEFI
specification does not specify the expected behaviour.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ronald Cron <***@arm.com<mailto:***@arm.com>>
Reviewed-by: Olivier Martin <***@arm.com<mailto:***@arm.com>>

Regards,
Olivier

-- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

ARM Limited, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2557590
ARM Holdings plc, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2548782

-- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

ARM Limited, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2557590
ARM Holdings plc, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2548782

-- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

ARM Limited, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2557590
ARM Holdings plc, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2548782

-- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

ARM Limited, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2557590
ARM Holdings plc, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2548782