Discussion:
[edk2] FV FvName in FV Ext Entry
Tim Lewis
2015-06-12 01:55:43 UTC
Permalink
Would someone care to document the changes that were made to add the FV Name to the FV volume header? It would be helpful for other folks to know what Intel is planning here, and how it fits in with the overall scheme. Also, how to turn off this feature so that it is not generated.

Thanks,

Tim
Gao, Liming
2015-06-15 06:00:31 UTC
Permalink
Tim:
Yes. We will update EDKII FDF and Build spec to describe this change. When the FvNameGuid entry is present in an [FV] section, the tools will generate an FvNameString entry in FV EXT header using the UiFvName. That means FvNameGuid and FvNameString will both be generated or not.

Thanks
Liming

From: Tim Lewis [mailto:***@insyde.com]
Sent: Friday, June 12, 2015 9:56 AM
To: edk2-***@lists.sourceforge.net
Subject: [edk2] FV FvName in FV Ext Entry

Would someone care to document the changes that were made to add the FV Name to the FV volume header? It would be helpful for other folks to know what Intel is planning here, and how it fits in with the overall scheme. Also, how to turn off this feature so that it is not generated.

Thanks,

Tim
Tim Lewis
2015-06-15 16:09:08 UTC
Permalink
Liming -

I think you should allow a flag to indicate whether it should be generated or not. We would prefer that it not be generated and that optional features in FVs be turned off by default.

Tim

From: Gao, Liming [mailto:***@intel.com]
Sent: Sunday, June 14, 2015 11:01 PM
To: edk2-***@lists.sourceforge.net
Subject: Re: [edk2] FV FvName in FV Ext Entry

Tim:
Yes. We will update EDKII FDF and Build spec to describe this change. When the FvNameGuid entry is present in an [FV] section, the tools will generate an FvNameString entry in FV EXT header using the UiFvName. That means FvNameGuid and FvNameString will both be generated or not.

Thanks
Liming

From: Tim Lewis [mailto:***@insyde.com]
Sent: Friday, June 12, 2015 9:56 AM
To: edk2-***@lists.sourceforge.net<mailto:edk2-***@lists.sourceforge.net>
Subject: [edk2] FV FvName in FV Ext Entry

Would someone care to document the changes that were made to add the FV Name to the FV volume header? It would be helpful for other folks to know what Intel is planning here, and how it fits in with the overall scheme. Also, how to turn off this feature so that it is not generated.

Thanks,

Tim
Tim Lewis
2015-06-15 18:34:07 UTC
Permalink
Liming -

Your e-mail answers part of my concern. The other part is: normally, changes to critical components are reviewed by the entire open-source community before they are checked in, not after. This is a new feature, with wide-ranging implications.

Tim

From: Gao, Liming [mailto:***@intel.com]
Sent: Sunday, June 14, 2015 11:01 PM
To: edk2-***@lists.sourceforge.net
Subject: Re: [edk2] FV FvName in FV Ext Entry

Tim:
Yes. We will update EDKII FDF and Build spec to describe this change. When the FvNameGuid entry is present in an [FV] section, the tools will generate an FvNameString entry in FV EXT header using the UiFvName. That means FvNameGuid and FvNameString will both be generated or not.

Thanks
Liming

From: Tim Lewis [mailto:***@insyde.com]
Sent: Friday, June 12, 2015 9:56 AM
To: edk2-***@lists.sourceforge.net<mailto:edk2-***@lists.sourceforge.net>
Subject: [edk2] FV FvName in FV Ext Entry

Would someone care to document the changes that were made to add the FV Name to the FV volume header? It would be helpful for other folks to know what Intel is planning here, and how it fits in with the overall scheme. Also, how to turn off this feature so that it is not generated.

Thanks,

Tim
Gao, Liming
2015-06-16 10:01:06 UTC
Permalink
Tim:
Agree. I will wait for more feedback, then consider them more for it. I know your comment is to introduce new flag to turn on/off it, not add it in FvNameGuid feature. Right?

Thanks
Liming
From: Tim Lewis [mailto:***@insyde.com]
Sent: Tuesday, June 16, 2015 2:34 AM
To: edk2-***@lists.sourceforge.net
Subject: Re: [edk2] FV FvName in FV Ext Entry

Liming -

Your e-mail answers part of my concern. The other part is: normally, changes to critical components are reviewed by the entire open-source community before they are checked in, not after. This is a new feature, with wide-ranging implications.

Tim

From: Gao, Liming [mailto:***@intel.com]
Sent: Sunday, June 14, 2015 11:01 PM
To: edk2-***@lists.sourceforge.net<mailto:edk2-***@lists.sourceforge.net>
Subject: Re: [edk2] FV FvName in FV Ext Entry

Tim:
Yes. We will update EDKII FDF and Build spec to describe this change. When the FvNameGuid entry is present in an [FV] section, the tools will generate an FvNameString entry in FV EXT header using the UiFvName. That means FvNameGuid and FvNameString will both be generated or not.

Thanks
Liming

From: Tim Lewis [mailto:***@insyde.com]
Sent: Friday, June 12, 2015 9:56 AM
To: edk2-***@lists.sourceforge.net<mailto:edk2-***@lists.sourceforge.net>
Subject: [edk2] FV FvName in FV Ext Entry

Would someone care to document the changes that were made to add the FV Name to the FV volume header? It would be helpful for other folks to know what Intel is planning here, and how it fits in with the overall scheme. Also, how to turn off this feature so that it is not generated.

Thanks,

Tim
Gao, Liming
2015-07-16 05:53:55 UTC
Permalink
Hi, all
After collect more feedback, we agree to introduce new flag to turn on/off it.

New design is to introduce new key FvNameString in [FV] section. It will be enabled only when user specifies this key in [FV] section. FvNameString is in FV ext header. And, FV ext header requires FvNameGuid. So, FvNameString will be enabled only when FvNameGuid is specified. Otherwise, BaseTools will report error message. If you have any comments for this design, please let me know.

[FV.FvName]
...
FvNameGuid = 6D99E806-3D38-42c2-A095-5F4300BFD7DC # require if FvNameString is TRUE
FvNameString = TRUE # enable it. NameString from FV title
FvNameString = FALSE # disable it.

Thanks
Liming
From: Gao, Liming [mailto:***@intel.com]
Sent: Tuesday, June 16, 2015 6:01 PM
To: edk2-***@lists.sourceforge.net
Subject: Re: [edk2] FV FvName in FV Ext Entry

Tim:
Agree. I will wait for more feedback, then consider them more for it. I know your comment is to introduce new flag to turn on/off it, not add it in FvNameGuid feature. Right?

Thanks
Liming
From: Tim Lewis [mailto:***@insyde.com]
Sent: Tuesday, June 16, 2015 2:34 AM
To: edk2-***@lists.sourceforge.net<mailto:edk2-***@lists.sourceforge.net>
Subject: Re: [edk2] FV FvName in FV Ext Entry

Liming -

Your e-mail answers part of my concern. The other part is: normally, changes to critical components are reviewed by the entire open-source community before they are checked in, not after. This is a new feature, with wide-ranging implications.

Tim

From: Gao, Liming [mailto:***@intel.com]
Sent: Sunday, June 14, 2015 11:01 PM
To: edk2-***@lists.sourceforge.net<mailto:edk2-***@lists.sourceforge.net>
Subject: Re: [edk2] FV FvName in FV Ext Entry

Tim:
Yes. We will update EDKII FDF and Build spec to describe this change. When the FvNameGuid entry is present in an [FV] section, the tools will generate an FvNameString entry in FV EXT header using the UiFvName. That means FvNameGuid and FvNameString will both be generated or not.

Thanks
Liming

From: Tim Lewis [mailto:***@insyde.com]
Sent: Friday, June 12, 2015 9:56 AM
To: edk2-***@lists.sourceforge.net<mailto:edk2-***@lists.sourceforge.net>
Subject: [edk2] FV FvName in FV Ext Entry

Would someone care to document the changes that were made to add the FV Name to the FV volume header? It would be helpful for other folks to know what Intel is planning here, and how it fits in with the overall scheme. Also, how to turn off this feature so that it is not generated.

Thanks,

Tim
El-Haj-Mahmoud, Samer
2015-07-16 06:13:22 UTC
Permalink
When is this flag going to be introduced?



From: Gao, Liming [mailto:***@intel.com]
Sent: Thursday, July 16, 2015 1:54 AM
To: edk2-***@lists.sourceforge.net
Subject: Re: [edk2] FV FvName in FV Ext Entry

Hi, all
After collect more feedback, we agree to introduce new flag to turn on/off it.

New design is to introduce new key FvNameString in [FV] section. It will be enabled only when user specifies this key in [FV] section. FvNameString is in FV ext header. And, FV ext header requires FvNameGuid. So, FvNameString will be enabled only when FvNameGuid is specified. Otherwise, BaseTools will report error message. If you have any comments for this design, please let me know.

[FV.FvName]
...
FvNameGuid = 6D99E806-3D38-42c2-A095-5F4300BFD7DC # require if FvNameString is TRUE
FvNameString = TRUE # enable it. NameString from FV title
FvNameString = FALSE # disable it.

Thanks
Liming
From: Gao, Liming [mailto:***@intel.com]
Sent: Tuesday, June 16, 2015 6:01 PM
To: edk2-***@lists.sourceforge.net<mailto:edk2-***@lists.sourceforge.net>
Subject: Re: [edk2] FV FvName in FV Ext Entry

Tim:
Agree. I will wait for more feedback, then consider them more for it. I know your comment is to introduce new flag to turn on/off it, not add it in FvNameGuid feature. Right?

Thanks
Liming
From: Tim Lewis [mailto:***@insyde.com]
Sent: Tuesday, June 16, 2015 2:34 AM
To: edk2-***@lists.sourceforge.net<mailto:edk2-***@lists.sourceforge.net>
Subject: Re: [edk2] FV FvName in FV Ext Entry

Liming -

Your e-mail answers part of my concern. The other part is: normally, changes to critical components are reviewed by the entire open-source community before they are checked in, not after. This is a new feature, with wide-ranging implications.

Tim

From: Gao, Liming [mailto:***@intel.com]
Sent: Sunday, June 14, 2015 11:01 PM
To: edk2-***@lists.sourceforge.net<mailto:edk2-***@lists.sourceforge.net>
Subject: Re: [edk2] FV FvName in FV Ext Entry

Tim:
Yes. We will update EDKII FDF and Build spec to describe this change. When the FvNameGuid entry is present in an [FV] section, the tools will generate an FvNameString entry in FV EXT header using the UiFvName. That means FvNameGuid and FvNameString will both be generated or not.

Thanks
Liming

From: Tim Lewis [mailto:***@insyde.com]
Sent: Friday, June 12, 2015 9:56 AM
To: edk2-***@lists.sourceforge.net<mailto:edk2-***@lists.sourceforge.net>
Subject: [edk2] FV FvName in FV Ext Entry

Would someone care to document the changes that were made to add the FV Name to the FV volume header? It would be helpful for other folks to know what Intel is planning here, and how it fits in with the overall scheme. Also, how to turn off this feature so that it is not generated.

Thanks,

Tim
Gao, Liming
2015-07-16 06:24:52 UTC
Permalink
Samer:
If no other comments, we will add this support next week.

Thanks
Liming
From: El-Haj-Mahmoud, Samer [mailto:samer.el-haj-***@hp.com]
Sent: Thursday, July 16, 2015 2:13 PM
To: Gao, Liming; edk2-***@lists.sourceforge.net
Cc: El-Haj-Mahmoud, Samer
Subject: RE: FV FvName in FV Ext Entry

When is this flag going to be introduced?



From: Gao, Liming [mailto:***@intel.com]
Sent: Thursday, July 16, 2015 1:54 AM
To: edk2-***@lists.sourceforge.net<mailto:edk2-***@lists.sourceforge.net>
Subject: Re: [edk2] FV FvName in FV Ext Entry

Hi, all
After collect more feedback, we agree to introduce new flag to turn on/off it.

New design is to introduce new key FvNameString in [FV] section. It will be enabled only when user specifies this key in [FV] section. FvNameString is in FV ext header. And, FV ext header requires FvNameGuid. So, FvNameString will be enabled only when FvNameGuid is specified. Otherwise, BaseTools will report error message. If you have any comments for this design, please let me know.

[FV.FvName]
...
FvNameGuid = 6D99E806-3D38-42c2-A095-5F4300BFD7DC # require if FvNameString is TRUE
FvNameString = TRUE # enable it. NameString from FV title
FvNameString = FALSE # disable it.

Thanks
Liming
From: Gao, Liming [mailto:***@intel.com]
Sent: Tuesday, June 16, 2015 6:01 PM
To: edk2-***@lists.sourceforge.net<mailto:edk2-***@lists.sourceforge.net>
Subject: Re: [edk2] FV FvName in FV Ext Entry

Tim:
Agree. I will wait for more feedback, then consider them more for it. I know your comment is to introduce new flag to turn on/off it, not add it in FvNameGuid feature. Right?

Thanks
Liming
From: Tim Lewis [mailto:***@insyde.com]
Sent: Tuesday, June 16, 2015 2:34 AM
To: edk2-***@lists.sourceforge.net<mailto:edk2-***@lists.sourceforge.net>
Subject: Re: [edk2] FV FvName in FV Ext Entry

Liming -

Your e-mail answers part of my concern. The other part is: normally, changes to critical components are reviewed by the entire open-source community before they are checked in, not after. This is a new feature, with wide-ranging implications.

Tim

From: Gao, Liming [mailto:***@intel.com]
Sent: Sunday, June 14, 2015 11:01 PM
To: edk2-***@lists.sourceforge.net<mailto:edk2-***@lists.sourceforge.net>
Subject: Re: [edk2] FV FvName in FV Ext Entry

Tim:
Yes. We will update EDKII FDF and Build spec to describe this change. When the FvNameGuid entry is present in an [FV] section, the tools will generate an FvNameString entry in FV EXT header using the UiFvName. That means FvNameGuid and FvNameString will both be generated or not.

Thanks
Liming

From: Tim Lewis [mailto:***@insyde.com]
Sent: Friday, June 12, 2015 9:56 AM
To: edk2-***@lists.sourceforge.net<mailto:edk2-***@lists.sourceforge.net>
Subject: [edk2] FV FvName in FV Ext Entry

Would someone care to document the changes that were made to add the FV Name to the FV volume header? It would be helpful for other folks to know what Intel is planning here, and how it fits in with the overall scheme. Also, how to turn off this feature so that it is not generated.

Thanks,

Tim

Loading...