[edk2] [PATCH] SourceLevelDebugPkg: Fix PEI debug timer regression

[Brian J. Johnson]

Recent changes to debug timer handling ended up leaving the timer
disabled in PEI. This made it impossible to stop execution in PEI
externally via the debugger. Enable the timer when
InitializeDebugAgent calls InitializeDebugAgentPhase2, as well as when
it returns directly.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Brian J. Johnson <***@sgi.com>
---
.../Library/DebugAgent/SecPeiDebugAgent/SecPeiDebugAgentLib.c
| 4 ++++
1 file changed, 4 insertions(+)

diff --git
a/SourceLevelDebugPkg/Library/DebugAgent/SecPeiDebugAgent/SecPeiDebugAgentLib.c
b/SourceLevelDebugPkg/Library/DebugAgent/SecPeiDebugAgent/SecPeiDebugAgentLib.c
index fcc7a4b..ea75742 100644
---
a/SourceLevelDebugPkg/Library/DebugAgent/SecPeiDebugAgent/SecPeiDebugAgentLib.c
+++
b/SourceLevelDebugPkg/Library/DebugAgent/SecPeiDebugAgent/SecPeiDebugAgentLib.c
@@ -684,6 +684,10 @@ InitializeDebugAgentPhase2 (
TriggerSoftInterrupt (MEMORY_READY_SIGNATURE);
}
//
+ // Enable Debug Timer interrupt
+ //
+ SaveAndSetDebugTimerInterrupt (TRUE);
+ //
// Enable CPU interrupts so debug timer interrupts can be delivered
//
EnableInterrupts ();

[Fan, Jeff]

Thanks!

Reviewed-by: Jeff Fan <***@intel.com>

-----Original Message-----
From: Brian J. Johnson [mailto:***@sgi.com]
Sent: Thursday, July 02, 2015 11:56 PM
To: edk2-***@lists.sourceforge.net
Subject: [edk2] [PATCH] SourceLevelDebugPkg: Fix PEI debug timer regression

Recent changes to debug timer handling ended up leaving the timer disabled in PEI. This made it impossible to stop execution in PEI externally via the debugger. Enable the timer when InitializeDebugAgent calls InitializeDebugAgentPhase2, as well as when it returns directly.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Brian J. Johnson <***@sgi.com>
---
.../Library/DebugAgent/SecPeiDebugAgent/SecPeiDebugAgentLib.c
| 4 ++++
1 file changed, 4 insertions(+)

diff --git
a/SourceLevelDebugPkg/Library/DebugAgent/SecPeiDebugAgent/SecPeiDebugAgentLib.c
b/SourceLevelDebugPkg/Library/DebugAgent/SecPeiDebugAgent/SecPeiDebugAgentLib.c
index fcc7a4b..ea75742 100644
---
a/SourceLevelDebugPkg/Library/DebugAgent/SecPeiDebugAgent/SecPeiDebugAgentLib.c
+++
b/SourceLevelDebugPkg/Library/DebugAgent/SecPeiDebugAgent/SecPeiDebugAgentLib.c
@@ -684,6 +684,10 @@ InitializeDebugAgentPhase2 (
TriggerSoftInterrupt (MEMORY_READY_SIGNATURE);
}
//
+ // Enable Debug Timer interrupt
+ //
+ SaveAndSetDebugTimerInterrupt (TRUE);
+ //
// Enable CPU interrupts so debug timer interrupts can be delivered
//
EnableInterrupts ();
--
1.9.1


------------------------------------------------------------------------------
Don't Limit Your Business. Reach for the Cloud.
GigeNET's Cloud Solutions provide you with the tools and support that
you need to offload your IT needs and focus on growing your business.
Configured For All Businesses. Start Your Cloud Today.
https://www.gigenetcloud.com/
_______________________________________________
edk2-devel mailing list
edk2-***@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel