Discussion:
[edk2] URGENT SVN screwup [Re: [PATCH 0/5] MdeModulePkg: clean up Properties Table implementation and adapt it to AArch64]
Ard Biesheuvel
2015-07-02 06:51:19 UTC
Permalink
Liming, Jordan, Jiewen.
I appeared to have screwed up something performing the push
Could you please rewind SVN to r17801 ?
Apologies for sounding a bit panicky, but it would be useful if those
commits could be removed before the sync to github (iow, in the next
10 minutes)

Sorry again for screwing up,

Thanks,
Ard.
Right, I think I have already selected one and replied "yes", which means all patches are OK to me.
OK, thanks. That was not obvious to me
I am about to commit all 5 patches right now.
Thanks,
Ard.
-----Original Message-----
From: Gao, Liming
Sent: Thursday, July 02, 2015 2:29 PM
To: Ard Biesheuvel
Cc: Yao, Jiewen; Gao, Liming
Subject: RE: [edk2] [PATCH 0/5] MdeModulePkg: clean up Properties Table implementation and adapt it to AArch64
Jiewen has agreed your full patches. You can add him as Reviewed-By.
Thanks
Liming
-----Original Message-----
Sent: Thursday, July 02, 2015 2:27 PM
To: Gao, Liming
Subject: Re: [edk2] [PATCH 0/5] MdeModulePkg: clean up Properties Table implementation and adapt it to AArch64
When will you plan to commit this patch set? Could you do it this week?
I would do it immediately if I had received acks for all patches.
Could you take a look at #1 and #4 please?
--
Ard.
-----Original Message-----
Sent: Tuesday, June 30, 2015 9:18 PM
Cc: Fleming, Matt
Subject: [edk2] [PATCH 0/5] MdeModulePkg: clean up Properties Table
implementation and adapt it to AArch64
This series applies some cleanups to the Properties Table feature
implementation, and updates it so that it may be used on AArch64
without violating the alignment restrictions imposed by the
architecture (i.e., runtime regions should be 64 KB
aligned)
MdeModulePkg: remove unused functions from
Core/Dxe/Misc/PropertiesTable.c
MdeModulePkg: make internal functions STATIC in
Core/Dxe/Misc/PropertiesTable.c
MdeModulePkg: rename PropertiesTableEnable to PcdPropertiesTableEnable
MdeModulePkg: move arch-specific allocation granularity defines to
DxeMain.h
MdeModulePkg: enforce arch-specific alignment for split regions
MdeModulePkg/Core/Dxe/DxeMain.h | 25 +++++
MdeModulePkg/Core/Dxe/DxeMain.inf | 2 +-
MdeModulePkg/Core/Dxe/Mem/Imem.h | 25 -----
MdeModulePkg/Core/Dxe/Misc/PropertiesTable.c | 112 +++++---------------
MdeModulePkg/MdeModulePkg.dec | 2 +-
5 files changed, 53 insertions(+), 113 deletions(-)
--
1.9.1
----------------------------------------------------------------------
-------- Don't Limit Your Business. Reach for the Cloud.
GigeNET's Cloud Solutions provide you with the tools and support that
you need to offload your IT needs and focus on growing your business.
Configured For All Businesses. Start Your Cloud Today.
https://www.gigenetcloud.com/
_______________________________________________
edk2-devel mailing list
https://lists.sourceforge.net/lists/listinfo/edk2-devel
Jordan Justen
2015-07-02 07:10:40 UTC
Permalink
Post by Ard Biesheuvel
Liming, Jordan, Jiewen.
I appeared to have screwed up something performing the push
Could you please rewind SVN to r17801 ?
Apologies for sounding a bit panicky, but it would be useful if those
commits could be removed before the sync to github (iow, in the next
10 minutes)
Whoops. Didn't see this in time.

I'll add a revert commit, and then sync the tree...

-Jordan
Jordan Justen
2015-07-02 07:29:38 UTC
Permalink
Post by Jordan Justen
Post by Ard Biesheuvel
Liming, Jordan, Jiewen.
I appeared to have screwed up something performing the push
Could you please rewind SVN to r17801 ?
Apologies for sounding a bit panicky, but it would be useful if those
commits could be removed before the sync to github (iow, in the next
10 minutes)
Whoops. Didn't see this in time.
I'll add a revert commit, and then sync the tree...
Done. Let me know if it doesn't look right.

-Jordan
Ard Biesheuvel
2015-07-02 07:30:12 UTC
Permalink
Post by Jordan Justen
Post by Jordan Justen
Post by Ard Biesheuvel
Liming, Jordan, Jiewen.
I appeared to have screwed up something performing the push
Could you please rewind SVN to r17801 ?
Apologies for sounding a bit panicky, but it would be useful if those
commits could be removed before the sync to github (iow, in the next
10 minutes)
Whoops. Didn't see this in time.
I'll add a revert commit, and then sync the tree...
Done. Let me know if it doesn't look right.
That looks fine.

Thanks and sorry for the trouble,
Ard.
Laszlo Ersek
2015-07-06 19:24:51 UTC
Permalink
Post by Ard Biesheuvel
Post by Jordan Justen
Post by Jordan Justen
Post by Ard Biesheuvel
Liming, Jordan, Jiewen.
I appeared to have screwed up something performing the push
Could you please rewind SVN to r17801 ?
Apologies for sounding a bit panicky, but it would be useful if those
commits could be removed before the sync to github (iow, in the next
10 minutes)
Whoops. Didn't see this in time.
I'll add a revert commit, and then sync the tree...
Done. Let me know if it doesn't look right.
That looks fine.
Thanks and sorry for the trouble,
It's always best to run

git svn dcommit --dry-run

first, and then eyeball the commit hashes that it prints against a "more
visual" tool, like "gitk". That makes it easier to catch patches that
are relevant only locally, and then the committer can do a git rebase
first, dropping the not-for-SVN patches, before the dcommit command.

(Sorry for sounding obvious.)

Thanks
Laszlo

Loading...