[edk2] [Patch] MdeModulePkg: Correct PcdConOutColumn help string.

Discussion:

Liming Gao

2015-07-15 06:53:55 UTC

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Liming Gao <***@intel.com>
---
MdeModulePkg/MdeModulePkg.dec | 2 +-
MdeModulePkg/MdeModulePkg.uni | Bin 166786 -> 166792 bytes
2 files changed, 1 insertion(+), 1 deletion(-)

diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.dec
index 623b07f..42f0435 100644
--- a/MdeModulePkg/MdeModulePkg.dec
+++ b/MdeModulePkg/MdeModulePkg.dec
@@ -949,11 +949,11 @@
## This PCD defines the Console output row. The default value is 25 according to UEFI spec.
# This PCD could be set to 0 then console output would be at max column and max row.
# @Prompt Console output row.
gEfiMdeModulePkgTokenSpaceGuid.PcdConOutRow|25|UINT32|0x40000006

- ## This PCD defines the Console output row. The default value is 80 according to UEFI spec.
+ ## This PCD defines the Console output column. The default value is 80 according to UEFI spec.
# This PCD could be set to 0 then console output would be at max column and max row.
# @Prompt Console output column.
gEfiMdeModulePkgTokenSpaceGuid.PcdConOutColumn|80|UINT32|0x40000007

## This PCD defines the video horizontal resolution.
diff --git a/MdeModulePkg/MdeModulePkg.uni b/MdeModulePkg/MdeModulePkg.uni
index b33060e79bf6ae54c18afb4feffdcf252583f5b5..e90e7d1e8fdeb0ead04bf689ddf83c1237aba855 100644
GIT binary patch
delta 34
qcmZpg&ebuUt6>Y{j~(2}4EYQ>45bXY40+Sv>oDqX*V)M!b_oF7V+?Wt

delta 22
ecmeB}&eb%Xt6>Y{j~&w`wlSJ)H`>V<b_oD(p$V4&

--
1.9.5.msysgit.0

Carsey, Jaben

2015-07-15 14:05:38 UTC

Permalink

Question: if row or col is zero, does that set both values to maximum?

-----Original Message-----
Sent: Tuesday, July 14, 2015 11:54 PM
Subject: [edk2] [Patch] MdeModulePkg: Correct PcdConOutColumn help string.
Contributed-under: TianoCore Contribution Agreement 1.0
---
MdeModulePkg/MdeModulePkg.dec | 2 +-
MdeModulePkg/MdeModulePkg.uni | Bin 166786 -> 166792 bytes
2 files changed, 1 insertion(+), 1 deletion(-)
diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.dec
index 623b07f..42f0435 100644
--- a/MdeModulePkg/MdeModulePkg.dec
+++ b/MdeModulePkg/MdeModulePkg.dec
@@ -949,11 +949,11 @@
## This PCD defines the Console output row. The default value is 25 according to UEFI spec.
# This PCD could be set to 0 then console output would be at max column and max row.
gEfiMdeModulePkgTokenSpaceGuid.PcdConOutRow|25|UINT32|0x40000006
- ## This PCD defines the Console output row. The default value is 80 according to UEFI spec.
+ ## This PCD defines the Console output column. The default value is 80 according to UEFI spec.
# This PCD could be set to 0 then console output would be at max column and max row.
gEfiMdeModulePkgTokenSpaceGuid.PcdConOutColumn|80|UINT32|0x40000007
## This PCD defines the video horizontal resolution.
diff --git a/MdeModulePkg/MdeModulePkg.uni b/MdeModulePkg/MdeModulePkg.uni
index b33060e79bf6ae54c18afb4feffdcf252583f5b5..e90e7d1e8fdeb0ead04bf689ddf83c1237aba855 100644
GIT binary patch
delta 34
qcmZpg&ebuUt6>Y{j~(2}4EYQ>45bXY40+Sv>oDqX*V)M!b_oF7V+?Wt
delta 22
ecmeB}&eb%Xt6>Y{j~&w`wlSJ)H`>V<b_oD(p$V4&
--
1.9.5.msysgit.0
------------------------------------------------------------------------------
Don't Limit Your Business. Reach for the Cloud.
GigeNET's Cloud Solutions provide you with the tools and support that
you need to offload your IT needs and focus on growing your business.
Configured For All Businesses. Start Your Cloud Today.
https://www.gigenetcloud.com/
_______________________________________________
edk2-devel mailing list
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Ni, Ruiyu

2015-07-16 02:41:35 UTC

Permalink

Jaben,
Partially right. When row and col is 0, core will try to use the native resolution of that monitor. Native resolution concept only applies to LCD/TFT monitor, not legacy CRT monitor. It may have maximum col, or maximum row, or both.

-----Original Message-----
Sent: Wednesday, July 15, 2015 10:06 PM
Subject: Re: [edk2] [Patch] MdeModulePkg: Correct PcdConOutColumn help
string.
Question: if row or col is zero, does that set both values to maximum?

-----Original Message-----
Sent: Tuesday, July 14, 2015 11:54 PM
Subject: [edk2] [Patch] MdeModulePkg: Correct PcdConOutColumn help

string.

Contributed-under: TianoCore Contribution Agreement 1.0
---
MdeModulePkg/MdeModulePkg.dec | 2 +-
MdeModulePkg/MdeModulePkg.uni | Bin 166786 -> 166792 bytes
2 files changed, 1 insertion(+), 1 deletion(-)
diff --git a/MdeModulePkg/MdeModulePkg.dec

b/MdeModulePkg/MdeModulePkg.dec

index 623b07f..42f0435 100644
--- a/MdeModulePkg/MdeModulePkg.dec
+++ b/MdeModulePkg/MdeModulePkg.dec
@@ -949,11 +949,11 @@
## This PCD defines the Console output row. The default value is 25

according to UEFI spec.

# This PCD could be set to 0 then console output would be at max

column and max row.
gEfiMdeModulePkgTokenSpaceGuid.PcdConOutRow|25|UINT32|0x4000000
6

- ## This PCD defines the Console output row. The default value is 80

according to UEFI spec.

+ ## This PCD defines the Console output column. The default value is 80

according to UEFI spec.

# This PCD could be set to 0 then console output would be at max

column and max row.
gEfiMdeModulePkgTokenSpaceGuid.PcdConOutColumn|80|UINT32|0x4000
0007

## This PCD defines the video horizontal resolution.
diff --git a/MdeModulePkg/MdeModulePkg.uni

b/MdeModulePkg/MdeModulePkg.uni

index

b33060e79bf6ae54c18afb4feffdcf252583f5b5..e90e7d1e8fdeb0ead04bf689
ddf83c1237aba855 100644

GIT binary patch
delta 34
qcmZpg&ebuUt6>Y{j~(2}4EYQ>45bXY40+Sv>oDqX*V)M!b_oF7V+?Wt
delta 22
ecmeB}&eb%Xt6>Y{j~&w`wlSJ)H`>V<b_oD(p$V4&
--
1.9.5.msysgit.0
------------------------------------------------------------------------------
Don't Limit Your Business. Reach for the Cloud.
GigeNET's Cloud Solutions provide you with the tools and support that
you need to offload your IT needs and focus on growing your business.
Configured For All Businesses. Start Your Cloud Today.
https://www.gigenetcloud.com/
_______________________________________________
edk2-devel mailing list
https://lists.sourceforge.net/lists/listinfo/edk2-devel

------------------------------------------------------------------------------
Don't Limit Your Business. Reach for the Cloud.
GigeNET's Cloud Solutions provide you with the tools and support that
you need to offload your IT needs and focus on growing your business.
Configured For All Businesses. Start Your Cloud Today.
https://www.gigenetcloud.com/
_______________________________________________
edk2-devel mailing list
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Ni, Ruiyu

2015-07-16 03:11:29 UTC

Permalink

Jaben,
I mixed PcdConOutColumn/PcdConOutRow and PcdVideoHorizontalResolution/PcdVideoVerticalResolution. My below explanation is for the PcdVideoHorizontalResolution/PcdVideoVerticalResolution.
You are completely right:) PcdConOutColumn/PcdConOutRow is the maximum column/row supported by the text console.

Thanks,
Ray

-----Original Message-----
Sent: Thursday, July 16, 2015 10:42 AM
Subject: Re: [edk2] [Patch] MdeModulePkg: Correct PcdConOutColumn help
string.
Jaben,
Partially right. When row and col is 0, core will try to use the native
resolution of that monitor. Native resolution concept only applies to
LCD/TFT monitor, not legacy CRT monitor. It may have maximum col, or
maximum row, or both.

-----Original Message-----
Sent: Wednesday, July 15, 2015 10:06 PM
Subject: Re: [edk2] [Patch] MdeModulePkg: Correct PcdConOutColumn

help

string.
Question: if row or col is zero, does that set both values to maximum?

-----Original Message-----
Sent: Tuesday, July 14, 2015 11:54 PM
Subject: [edk2] [Patch] MdeModulePkg: Correct PcdConOutColumn help

string.

b/MdeModulePkg/MdeModulePkg.dec

index 623b07f..42f0435 100644
--- a/MdeModulePkg/MdeModulePkg.dec
+++ b/MdeModulePkg/MdeModulePkg.dec
@@ -949,11 +949,11 @@
## This PCD defines the Console output row. The default value is 25

according to UEFI spec.

# This PCD could be set to 0 then console output would be at max

column and max row.

gEfiMdeModulePkgTokenSpaceGuid.PcdConOutRow|25|UINT32|0x4000000

- ## This PCD defines the Console output row. The default value is 80

according to UEFI spec.

+ ## This PCD defines the Console output column. The default value is

according to UEFI spec.

# This PCD could be set to 0 then console output would be at max

column and max row.

gEfiMdeModulePkgTokenSpaceGuid.PcdConOutColumn|80|UINT32|0x4000

0007

## This PCD defines the video horizontal resolution.
diff --git a/MdeModulePkg/MdeModulePkg.uni

b/MdeModulePkg/MdeModulePkg.uni

index

b33060e79bf6ae54c18afb4feffdcf252583f5b5..e90e7d1e8fdeb0ead04bf689

ddf83c1237aba855 100644

Zeng, Star

2015-07-16 01:43:07 UTC

Permalink

-----Original Message-----
Sent: Wednesday, July 15, 2015 2:54 PM
Subject: [edk2] [Patch] MdeModulePkg: Correct PcdConOutColumn help string.
Contributed-under: TianoCore Contribution Agreement 1.0
---
MdeModulePkg/MdeModulePkg.dec | 2 +-
MdeModulePkg/MdeModulePkg.uni | Bin 166786 -> 166792 bytes
2 files changed, 1 insertion(+), 1 deletion(-)
diff --git a/MdeModulePkg/MdeModulePkg.dec
b/MdeModulePkg/MdeModulePkg.dec index 623b07f..42f0435 100644
--- a/MdeModulePkg/MdeModulePkg.dec
+++ b/MdeModulePkg/MdeModulePkg.dec
@@ -949,11 +949,11 @@
## This PCD defines the Console output row. The default value is 25
according to UEFI spec.
# This PCD could be set to 0 then console output would be at max column and max row.
gEfiMdeModulePkgTokenSpaceGuid.PcdConOutRow|25|UINT32|0x40000006
- ## This PCD defines the Console output row. The default value is 80
according to UEFI spec.
+ ## This PCD defines the Console output column. The default value is 80
according to UEFI spec.
# This PCD could be set to 0 then console output would be at max column and max row.
gEfiMdeModulePkgTokenSpaceGuid.PcdConOutColumn|80|UINT32|0x4000000
7
## This PCD defines the video horizontal resolution.
diff --git a/MdeModulePkg/MdeModulePkg.uni
b/MdeModulePkg/MdeModulePkg.uni index
b33060e79bf6ae54c18afb4feffdcf252583f5b5..e90e7d1e8fdeb0ead04bf689ddf
83c1237aba855 100644 GIT binary patch delta 34
qcmZpg&ebuUt6>Y{j~(2}4EYQ>45bXY40+Sv>oDqX*V)M!b_oF7V+?Wt
delta 22
ecmeB}&eb%Xt6>Y{j~&w`wlSJ)H`>V<b_oD(p$V4&
--
1.9.5.msysgit.0
------------------------------------------------------------------------------
Don't Limit Your Business. Reach for the Cloud.
GigeNET's Cloud Solutions provide you with the tools and support that
you need to offload your IT needs and focus on growing your business.
Configured For All Businesses. Start Your Cloud Today.
https://www.gigenetcloud.com/
_______________________________________________
edk2-devel mailing list
https://lists.sourceforge.net/lists/listinfo/edk2-devel