[edk2] [BUG] NetworkPkg/UefiPxeBcDxe, MdeModulePkg/Netwrk/UefiPxeBcDxe: EfiPxeBcDhcp() should not return EFI_ALREADY_STARTED

[Olivier Martin]

From the UEFI specification, it is not expected EfiPxeBcDhcp() to return EFI_ALREADY_STARTED.

But in the current implementation, EfiPxeBcDhcp() may return EFI_ALREADY_STARTED if the DHCP configuration has already been started.

If I had to fix the issue, I would probably make this function returns EFI_SUCCESS if the DHCP has already been configured (ie: return EFI_ALREADY_STARTED).

-- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

ARM Limited, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2557590
ARM Holdings plc, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2548782

[Fu, Siyuan]

Hi, Martin

Thanks for your report, I will follow up to fix it.

Best Regards,
Siyuan

From: Olivier Martin [mailto:***@arm.com]
Sent: Tuesday, July 14, 2015 11:10 PM
To: Fu, Siyuan; Tian, Feng
Cc: edk2-***@lists.sourceforge.net
Subject: [BUG] NetworkPkg/UefiPxeBcDxe, MdeModulePkg/Netwrk/UefiPxeBcDxe: EfiPxeBcDhcp() should not return EFI_ALREADY_STARTED

From the UEFI specification, it is not expected EfiPxeBcDhcp() to return EFI_ALREADY_STARTED.

But in the current implementation, EfiPxeBcDhcp() may return EFI_ALREADY_STARTED if the DHCP configuration has already been started.

If I had to fix the issue, I would probably make this function returns EFI_SUCCESS if the DHCP has already been configured (ie: return EFI_ALREADY_STARTED).

-- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

ARM Limited, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2557590
ARM Holdings plc, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2548782