[edk2] 'ArmPlatformPkg/ArmVExpressDxe: Change FDT default file names' breaks the build

[Ard Biesheuvel]

Hi Olivier,

Your patch 'ArmPlatformPkg/ArmVExpressDxe: Change FDT default file
names' has broken the FVP build in a non-trivial way:

This part of the FDF:

"""
!ifdef $(DTB_DIR)
#
# Embed flattened device tree (FDT) images for all known
# variants of this platform
#
FILE RAW = PCD (gArmVExpressTokenSpaceGuid.PcdFdtFvpBaseAEMv8x4GicV2) {
$(DTB_DIR)/fvp-base-gicv2-psci.dtb
}
FILE RAW = PCD (gArmVExpressTokenSpaceGuid.PcdFdtFvpBaseAEMv8x4GicV2Legacy) {
$(DTB_DIR)/fvp-base-gicv2legacy-psci.dtb
}
FILE RAW = PCD (gArmVExpressTokenSpaceGuid.PcdFdtFvpBaseAEMv8x4GicV3) {
$(DTB_DIR)/fvp-base-gicv3-psci.dtb
}
FILE RAW = PCD (gArmVExpressTokenSpaceGuid.PcdFdtFvpFoundationGicV2) {
$(DTB_DIR)/fvp-foundation-gicv2-psci.dtb
}
FILE RAW = PCD (gArmVExpressTokenSpaceGuid.PcdFdtFvpFoundationGicV2Legacy) {
$(DTB_DIR)/fvp-foundation-gicv2legacy-psci.dtb
}
FILE RAW = PCD (gArmVExpressTokenSpaceGuid.PcdFdtFvpFoundationGicV3) {
$(DTB_DIR)/fvp-foundation-gicv3-psci.dtb
}
!endif
"""

now generates build failures when DTB_DIR is set, and there is no easy
fix since the PCDs were removed and the underlying functionality as
well.

Since the patch has not been sent to the list for review, may I
propose that you revert it? Then we can discuss an approach for the
underlying issue rather than paper over the problems it has created.

Thanks,
Ard.

[Olivier Martin]

That's a fair comment. I will revert the patch. Sorry for the inconvenience.

-----Original Message-----
From: Ard Biesheuvel [mailto:***@linaro.org]
Sent: 07 July 2015 22:08
To: edk2-***@lists.sourceforge.net; Olivier Martin
Subject: 'ArmPlatformPkg/ArmVExpressDxe: Change FDT default file names' breaks the build

Hi Olivier,

Your patch 'ArmPlatformPkg/ArmVExpressDxe: Change FDT default file names' has broken the FVP build in a non-trivial way:

This part of the FDF:

"""
!ifdef $(DTB_DIR)
#
# Embed flattened device tree (FDT) images for all known
# variants of this platform
#
FILE RAW = PCD (gArmVExpressTokenSpaceGuid.PcdFdtFvpBaseAEMv8x4GicV2) {
$(DTB_DIR)/fvp-base-gicv2-psci.dtb
}
FILE RAW = PCD (gArmVExpressTokenSpaceGuid.PcdFdtFvpBaseAEMv8x4GicV2Legacy) {
$(DTB_DIR)/fvp-base-gicv2legacy-psci.dtb
}
FILE RAW = PCD (gArmVExpressTokenSpaceGuid.PcdFdtFvpBaseAEMv8x4GicV3) {
$(DTB_DIR)/fvp-base-gicv3-psci.dtb
}
FILE RAW = PCD (gArmVExpressTokenSpaceGuid.PcdFdtFvpFoundationGicV2) {
$(DTB_DIR)/fvp-foundation-gicv2-psci.dtb
}
FILE RAW = PCD (gArmVExpressTokenSpaceGuid.PcdFdtFvpFoundationGicV2Legacy) {
$(DTB_DIR)/fvp-foundation-gicv2legacy-psci.dtb
}
FILE RAW = PCD (gArmVExpressTokenSpaceGuid.PcdFdtFvpFoundationGicV3) {
$(DTB_DIR)/fvp-foundation-gicv3-psci.dtb
}
!endif
"""

now generates build failures when DTB_DIR is set, and there is no easy fix since the PCDs were removed and the underlying functionality as well.

Since the patch has not been sent to the list for review, may I propose that you revert it? Then we can discuss an approach for the underlying issue rather than paper over the problems it has created.

Thanks,
Ard.


-- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

ARM Limited, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2557590
ARM Holdings plc, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2548782

[Ard Biesheuvel]

Post by Olivier Martin
That's a fair comment. I will revert the patch. Sorry for the inconvenience.

OK, thanks.
--
Ard.

Post by Olivier Martin
-----Original Message-----
Sent: 07 July 2015 22:08
Subject: 'ArmPlatformPkg/ArmVExpressDxe: Change FDT default file names' breaks the build
Hi Olivier,
"""
!ifdef $(DTB_DIR)
#
# Embed flattened device tree (FDT) images for all known
# variants of this platform
#
FILE RAW = PCD (gArmVExpressTokenSpaceGuid.PcdFdtFvpBaseAEMv8x4GicV2) {
$(DTB_DIR)/fvp-base-gicv2-psci.dtb
}
FILE RAW = PCD (gArmVExpressTokenSpaceGuid.PcdFdtFvpBaseAEMv8x4GicV2Legacy) {
$(DTB_DIR)/fvp-base-gicv2legacy-psci.dtb
}
FILE RAW = PCD (gArmVExpressTokenSpaceGuid.PcdFdtFvpBaseAEMv8x4GicV3) {
$(DTB_DIR)/fvp-base-gicv3-psci.dtb
}
FILE RAW = PCD (gArmVExpressTokenSpaceGuid.PcdFdtFvpFoundationGicV2) {
$(DTB_DIR)/fvp-foundation-gicv2-psci.dtb
}
FILE RAW = PCD (gArmVExpressTokenSpaceGuid.PcdFdtFvpFoundationGicV2Legacy) {
$(DTB_DIR)/fvp-foundation-gicv2legacy-psci.dtb
}
FILE RAW = PCD (gArmVExpressTokenSpaceGuid.PcdFdtFvpFoundationGicV3) {
$(DTB_DIR)/fvp-foundation-gicv3-psci.dtb
}
!endif
"""
now generates build failures when DTB_DIR is set, and there is no easy fix since the PCDs were removed and the underlying functionality as well.
Since the patch has not been sent to the list for review, may I propose that you revert it? Then we can discuss an approach for the underlying issue rather than paper over the problems it has created.
Thanks,
Ard.
-- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
ARM Limited, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2557590
ARM Holdings plc, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2548782