[edk2] How to send patches against UTF-16 .uni files for review?

[Bruce Cran]

I have some fixes to Vlv2TbltDevicePkg/PlatformSetupDxe/VfrStrings.uni
such as changing "Congfiguration" to "Configuration", but since it's
UTF-16 git treats it as binary.

How should we send patches for such files to edk2-devel for review?

[Laszlo Ersek]

Post by Bruce Cran
I have some fixes to Vlv2TbltDevicePkg/PlatformSetupDxe/VfrStrings.uni
such as changing "Congfiguration" to "Configuration", but since it's
UTF-16 git treats it as binary.
How should we send patches for such files to edk2-devel for review?

Jordan tried to introduce UTF-8 encoded UNI files recently. I'm
uncertain about the result of that work.

With the current UCS-2 encoded UNI files, you can send a binary
(approximately: uuencoded) patch with git. (Git-format-patch will handle
that automatically.) Then reviewers can apply (or pull, if you push them
first) the patches. Using the hints discussed earlier in

http://thread.gmane.org/gmane.comp.bios.tianocore.devel/6351

once applied, the local commits can be shown / reviewed easily.

Review comments cannot really be tied to the relevant parts of the
(approximately uuencoded) patch, unfortunately.

Alternatively, the traditional (non-)solution has been to post the
modified UNI file in full, as an attachment...

So, my recommendation:
- employ the hints from under the above link
- review your own work in git
- push your branch to github
- post the (binary) patches, reference your branch on github
- wait for reviews

Thanks
Laszlo

------------------------------------------------------------------------------

[Jordan Justen]

Post by Laszlo Ersek

Post by Bruce Cran
I have some fixes to Vlv2TbltDevicePkg/PlatformSetupDxe/VfrStrings.uni
such as changing "Congfiguration" to "Configuration", but since it's
UTF-16 git treats it as binary.
How should we send patches for such files to edk2-devel for review?

Jordan tried to introduce UTF-8 encoded UNI files recently. I'm
uncertain about the result of that work.

I hope to send out v3 soon based on Mike's feedback.

-Jordan

Post by Laszlo Ersek
With the current UCS-2 encoded UNI files, you can send a binary
(approximately: uuencoded) patch with git. (Git-format-patch will handle
that automatically.) Then reviewers can apply (or pull, if you push them
first) the patches. Using the hints discussed earlier in
http://thread.gmane.org/gmane.comp.bios.tianocore.devel/6351
once applied, the local commits can be shown / reviewed easily.
Review comments cannot really be tied to the relevant parts of the
(approximately uuencoded) patch, unfortunately.
Alternatively, the traditional (non-)solution has been to post the
modified UNI file in full, as an attachment...
- employ the hints from under the above link
- review your own work in git
- push your branch to github
- post the (binary) patches, reference your branch on github
- wait for reviews
Thanks
Laszlo
------------------------------------------------------------------------------
_______________________________________________
edk2-devel mailing list
https://lists.sourceforge.net/lists/listinfo/edk2-devel

------------------------------------------------------------------------------