Discussion:
[edk2] [PATCH] MdeModulePkg PcdDxe: TokenNumber should start from 1.
Star Zeng
2015-06-10 06:32:59 UTC
Permalink
Because 0 is reserved as invalid token number.

Cc: Liming Gao <***@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng <***@intel.com>
---
Universal/PCD/Dxe/Service.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Universal/PCD/Dxe/Service.c b/Universal/PCD/Dxe/Service.c
index 9b4701b..cf5f244 100644
--- a/Universal/PCD/Dxe/Service.c
+++ b/Universal/PCD/Dxe/Service.c
@@ -1864,7 +1864,7 @@ VariableLockDynamicHiiPcd (
//
// Go through PCD database to find out DynamicHii PCDs.
//
- for (TokenNumber = 0; TokenNumber < LocalTokenCount; TokenNumber++) {
+ for (TokenNumber = 1; TokenNumber <= LocalTokenCount; TokenNumber++) {
if (IsPeiDb) {
LocalTokenNumber = GetLocalTokenNumber (TRUE, TokenNumber);
} else {
--
1.9.5.msysgit.0


------------------------------------------------------------------------------
Gao, Liming
2015-06-10 07:45:40 UTC
Permalink
Reviewed-by: Liming Gao <***@intel.com>

-----Original Message-----
From: Zeng, Star
Sent: Wednesday, June 10, 2015 2:33 PM
To: edk2-***@lists.sourceforge.net
Cc: Gao, Liming
Subject: [PATCH] MdeModulePkg PcdDxe: TokenNumber should start from 1.

Because 0 is reserved as invalid token number.

Cc: Liming Gao <***@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng <***@intel.com>
---
Universal/PCD/Dxe/Service.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Universal/PCD/Dxe/Service.c b/Universal/PCD/Dxe/Service.c index 9b4701b..cf5f244 100644
--- a/Universal/PCD/Dxe/Service.c
+++ b/Universal/PCD/Dxe/Service.c
@@ -1864,7 +1864,7 @@ VariableLockDynamicHiiPcd (
//
// Go through PCD database to find out DynamicHii PCDs.
//
- for (TokenNumber = 0; TokenNumber < LocalTokenCount; TokenNumber++) {
+ for (TokenNumber = 1; TokenNumber <= LocalTokenCount; TokenNumber++)
+ {
if (IsPeiDb) {
LocalTokenNumber = GetLocalTokenNumber (TRUE, TokenNumber);
} else {
--
1.9.5.msysgit.0


------------------------------------------------------------------------------
Loading...